Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for win_get_url module (Fixes #39151) #39152

Merged
merged 1 commit into from Apr 24, 2018
Merged

Fix for win_get_url module (Fixes #39151) #39152

merged 1 commit into from Apr 24, 2018

Conversation

Gianlu
Copy link
Contributor

@Gianlu Gianlu commented Apr 23, 2018

SUMMARY

Bugfix in win_get_url module

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_get_url

ANSIBLE VERSION
ansible 2.5.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/usr/share/ansible/modules']
  ansible python module location = /usr/lib/python2.7/dist-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.13 (default, Nov 24 2017, 17:33:09) [GCC 6.3.0 20170516]
ADDITIONAL INFORMATION

This pull request fixes issue #39151.

before:
changed:true
after:
changed:false

@ansibot
Copy link
Contributor

ansibot commented Apr 23, 2018

cc @dagwieers @jborean93 @jhawkesworth @nitzmahone @tksarah
click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Apr 23, 2018
@jborean93
Copy link
Contributor

Looks good @Gianlu, just kicking off the PR again to hopefully get a passing build.

@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Apr 24, 2018
@jborean93 jborean93 merged commit 0c96863 into ansible:devel Apr 24, 2018
jborean93 pushed a commit to jborean93/ansible that referenced this pull request Apr 24, 2018
@Gianlu @jborean93
Fix for win_get_url module (ansible#39152)
4bfcd5c 
(cherry picked from commit 0c96863)
@jborean93 jborean93 mentioned this pull request Apr 24, 2018
Merged
@jborean93
Copy link
Contributor

Backport PR for stable-2.5 #39207

jborean93 added a commit that referenced this pull request Apr 24, 2018
@jborean93
Fix for win_get_url module (Fixes #39151) - 2.5 backport (#39207)
250d5b7 
* Fix for win_get_url module (#39152)


(cherry picked from commit 0c96863)

* Added changelog fragment
@jborean93 jborean93 mentioned this pull request Apr 24, 2018
Closed
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 12, 2018
@Gianlu
Fix for win_get_url module (ansible#39152)
0d9fc04
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
@Gianlu
Fix for win_get_url module (ansible#39152)
776eff6
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
@Gianlu
Fix for win_get_url module (ansible#39152)
814358d
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@Gianlu
Fix for win_get_url module (ansible#39152)
e87169b
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@Gianlu
Fix for win_get_url module (ansible#39152)
4c4f35c
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@Gianlu @ilicmilan
Fix for win_get_url module (ansible#39152)
7172060
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jborean93 jborean93 jborean93 approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Gianlu @ansibot @jborean93