removes broken link to old module name #39249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acozine
added this to Docsite work
in Ansible-maintained Collections Documentation
via automation
ansibot
added
community_review
bcoca
reviewed
Apr 24, 2018
| @@ -21,7 +21,7 @@ | |||
| description: | |||
| - makes a computer speak! Amuse your friends, annoy your coworkers! | |||
| notes: | |||
| - In 2.5, this module has been renamed from M(osx_say) into M(say). | |||
| - In 2.5, this module has been renamed from ``osx_say`` to M(say). | |||
There was a problem hiding this comment.
osx_say is still there as a symlink, unsure if this is the correct solution as this will be the case with any aliased module.
There was a problem hiding this comment.
Please change to:
from C(osx_say) to M(say)
No need to have a link from say to osx_say, as you'd end up on the same page
acozine
force-pushed
the
say_module_docs_fix
branch
from
3f32296
to
95ad31b
Compare
|
@gundalow fixed, thanks |
acozine
moved this from Docsite work
to In progress
in Ansible-maintained Collections Documentation
gundalow
approved these changes
Apr 24, 2018
Ansible-maintained Collections Documentation
automation
moved this from In progress
to Done
Apr 25, 2018
acozine
moved this from Done
to Needs Backport to 2.5
in Ansible-maintained Collections Documentation
acozine
pushed a commit
to acozine/ansible
that referenced
this pull request
Apr 25, 2018
acozine
pushed a commit
that referenced
this pull request
Apr 25, 2018
acozine
moved this from Needs Backport to 2.5
to Done
in Ansible-maintained Collections Documentation
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 12, 2018
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 14, 2018
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 14, 2018
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 15, 2018
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 15, 2018
ilicmilan
pushed a commit
to ilicmilan/ansible
that referenced
this pull request
Nov 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
As part of making all rST warnings fatal on Shippable, we are eliminating warnings from the docs build. This PR addresses one of these:
saymodule contains a link to its old name, triggering aWARNING: undefined labelerror. This PR retains the text but removes the link.ISSUE TYPE
COMPONENT NAME
say module
ANSIBLE VERSION
2.5