Don't skip conditional exception on includes #39377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ansible#33632 Signed-off-by: Patrick Ringl <patrick_@freenet.de>
ansibot
added
bug
sivel
removed
the
needs_triage
|
Unstable test, unrelated to this PR. |
This was referenced Apr 26, 2018
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 12, 2018
* task_executor.py: Raise 'conditional exception' in case of 'include_*' Fixes ansible#33632 Signed-off-by: Patrick Ringl <patrick_@freenet.de> * Re-organize tests, add static include test with undefined var * Remove unnecessary conditional
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 14, 2018
* task_executor.py: Raise 'conditional exception' in case of 'include_*' Fixes ansible#33632 Signed-off-by: Patrick Ringl <patrick_@freenet.de> * Re-organize tests, add static include test with undefined var * Remove unnecessary conditional
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 14, 2018
* task_executor.py: Raise 'conditional exception' in case of 'include_*' Fixes ansible#33632 Signed-off-by: Patrick Ringl <patrick_@freenet.de> * Re-organize tests, add static include test with undefined var * Remove unnecessary conditional
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 15, 2018
* task_executor.py: Raise 'conditional exception' in case of 'include_*' Fixes ansible#33632 Signed-off-by: Patrick Ringl <patrick_@freenet.de> * Re-organize tests, add static include test with undefined var * Remove unnecessary conditional
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 15, 2018
* task_executor.py: Raise 'conditional exception' in case of 'include_*' Fixes ansible#33632 Signed-off-by: Patrick Ringl <patrick_@freenet.de> * Re-organize tests, add static include test with undefined var * Remove unnecessary conditional
ilicmilan
pushed a commit
to ilicmilan/ansible
that referenced
this pull request
Nov 7, 2018
* task_executor.py: Raise 'conditional exception' in case of 'include_*' Fixes ansible#33632 Signed-off-by: Patrick Ringl <patrick_@freenet.de> * Re-organize tests, add static include test with undefined var * Remove unnecessary conditional
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In fc3a444 we added special handling of conditional exceptions on includes due to use with tags.
The specific scenarios in #12843 no longer trigger the fix from the above commit due to 2c20579
Fixes #37892
This PR combines and supersedes:
ISSUE TYPE
COMPONENT NAME
lib/ansible/executor/task_executor.py
ANSIBLE VERSION
ADDITIONAL INFORMATION