Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change except Error when trying to get a missing option #39406

Merged
merged 1 commit into from Apr 27, 2018
Merged

Change except Error when trying to get a missing option #39406

merged 1 commit into from Apr 27, 2018

Conversation

jborean93
Copy link
Contributor

SUMMARY

When calling ActionBase .get_option and the option does not exist, it raises an AnsibleError not KeyError

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

action/init.py

ANSIBLE VERSION
devel

@abadger
Copy link
Contributor

abadger commented Apr 27, 2018

Looks good. +1.

@jborean93 jborean93 requested a review from bcoca April 27, 2018 04:19
@ansibot
Copy link
Contributor

ansibot commented Apr 27, 2018

cc @nitzmahone
click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 27, 2018
@bcoca bcoca added this to To Do in 2.5.x blocker list via automation Apr 27, 2018
@bcoca bcoca merged commit 25dea1f into ansible:devel Apr 27, 2018
@bcoca bcoca mentioned this pull request Apr 27, 2018
Merged
@bcoca bcoca moved this from To Do to Done in 2.5.x blocker list Apr 27, 2018
@jborean93
Copy link
Contributor Author

Thanks @bcoca

@jborean93 jborean93 deleted the get_option_missing branch June 20, 2018 12:02
@ansible ansible locked and limited conversation to collaborators Apr 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bcoca bcoca Awaiting requested review from bcoca

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
No open projects
2.5.x blocker list
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jborean93 @abadger @ansibot @bcoca