Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

facts: remove duplicate device vendor and model assignment #39419

Merged
merged 1 commit into from May 24, 2018
Merged

facts: remove duplicate device vendor and model assignment #39419

merged 1 commit into from May 24, 2018

Conversation

alfredodeza
Copy link
Contributor

Signed-off-by: Alfredo Deza adeza@redhat.com

SUMMARY

The hardware/linux.py facts is re-assigning the vendor and model for a device. This is not needed as it is already taken care of a few lines above (line 592 and 593)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

linux (module_utils/facts/hardware/linux.py)

ANSIBLE VERSION
 ansible --version
ansible 2.6.0 (linux-fact-cleanup e594a4c9e7) last updated 2018/04/27 09:22:13 (GMT -400)
  config file = /Users/alfredo/.ansible.cfg
  configured module search path = [u'/Users/alfredo/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/alfredo/python/ansible/lib/ansible
  executable location = /Users/alfredo/.virtualenvs/ansible/bin/ansible
  python version = 2.7.8 (v2.7.8:ee879c0ffa11, Jun 29 2014, 21:07:35) [GCC 4.2.1 (Apple Inc. build 5666) (dot 3)]

facts: remove duplicate device vendor and model assignment
e594a4c 
Signed-off-by: Alfredo Deza <adeza@redhat.com>
@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 27, 2018
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Apr 27, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 7, 2018
@ansibot ansibot added the affects_2.6 This issue/PR affects Ansible v2.6 label May 23, 2018
@maxamillion
Copy link
Contributor

merging, the tests instability was about a dnf repo cache issue in one of the fedora container runs and is not related to this change.

@maxamillion maxamillion merged commit 2d0891e into ansible:devel May 24, 2018
gothicx pushed a commit to gothicx/ansible that referenced this pull request Jun 9, 2018
@alfredodeza @gothicx
facts: remove duplicate device vendor and model assignment (ansible#3…
92941f8 
…9419)

Signed-off-by: Alfredo Deza <adeza@redhat.com>
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@alfredodeza
facts: remove duplicate device vendor and model assignment (ansible#3…
c867527 
…9419)

Signed-off-by: Alfredo Deza <adeza@redhat.com>
@ansible ansible locked and limited conversation to collaborators May 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.6 This issue/PR affects Ansible v2.6 bug This issue/PR relates to a bug. new_contributor This PR is the first contribution by a new community member. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alfredodeza @maxamillion @ansibot @s-hertel