Need to convert filenames to byte strings before using them in APIs #39424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
bug
Under a non-utf-8 locale (for instance, LC_ALL=C), passing a non-ascii filename to many APIs will traceback. Fix that by explicitly converting to byte strings before passing to external APIs. May fix ansible#27262
abadger
force-pushed
the
template-encoding-ascii-locale
branch
from
2ad11e3
to
81f3b4f
Compare
s-hertel
removed
the
needs_triage
ansibot
added
needs_revision
|
Failures are related to httpbin.org which are known at the moment. Unrelated to this PR. Merging to devel |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under a non-utf-8 locale (for instance, LC_ALL=C), passing a non-ascii
filename to many APIs will traceback. Fix that by explicitly converting
to byte strings before passing to external APIs.
May fix #27262
ISSUE TYPE
COMPONENT NAME
lib/ansible/plugins/action/template.py
ANSIBLE VERSION