-
Notifications
You must be signed in to change notification settings - Fork 23.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure handlers have proper parent #39426
Conversation
FYI, before this change, the new integration test produces:
|
* Ensure role handlers are parented correctly. Fixes ansible#36518 * Add delegate_to test for include_role handlers
* Ensure role handlers are parented correctly. Fixes ansible#36518 * Add delegate_to test for include_role handlers
* Ensure role handlers are parented correctly. Fixes ansible#36518 * Add delegate_to test for include_role handlers
* Ensure role handlers are parented correctly. Fixes ansible#36518 * Add delegate_to test for include_role handlers
* Ensure role handlers are parented correctly. Fixes ansible#36518 * Add delegate_to test for include_role handlers
This issue not resolved yet. I have been facing similar issue with both Ansible 2.6.1 and 2.6.2.
I have tried same code with 2.4.3 it's working expected. |
@SivaKrishna05 |
@sivel you mean to say that's expected behavior and nothing to do with next Ansible version updates |
I'm still seeing this issue on 2.6.5, but I suspect it's related to a That is, the workflow is slightly more complex. Does |
Scratch that. The wrong parent is still being recorded. The |
* Ensure role handlers are parented correctly. Fixes ansible#36518 * Add delegate_to test for include_role handlers
SUMMARY
This PR ensures that handlers have the correct parent. This change does for handlers what tasks already had done.
This ensures that things like the following apply to handlers:
Fixes #36518
Additionally, on a small note,
task_list.extend
is in place and returns nothing, don't assign tot
.ISSUE TYPE
COMPONENT NAME
ANSIBLE VERSION
ADDITIONAL INFORMATION