Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_s3: don't decrypt file before uploading - fixes #39287 #39634

Merged
merged 2 commits into from
Jun 6, 2018
Merged

aws_s3: don't decrypt file before uploading - fixes #39287 #39634

merged 2 commits into from
Jun 6, 2018

Conversation

s-hertel
Copy link
Contributor

@s-hertel s-hertel commented May 2, 2018

SUMMARY

Prior to 4d58d16 files were never decrypted before uploading. Fixes #39287
Backport candidate

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/plugins/action/aws_s3.py

ANSIBLE VERSION
2.6.0

@s-hertel s-hertel requested review from willthames and ryansb May 2, 2018 19:25
@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels May 2, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label May 3, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 11, 2018
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 15, 2018
@s-hertel
Copy link
Contributor Author

Rebased after #39023 was merged.

@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels May 15, 2018
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label May 15, 2018
@ansibot ansibot added affects_2.6 This issue/PR affects Ansible v2.6 stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels May 23, 2018
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jun 5, 2018
@s-hertel
Copy link
Contributor Author

s-hertel commented Jun 6, 2018

bot_status

@ansibot
Copy link
Contributor

ansibot commented Jun 6, 2018

Components

changelogs/fragments/aws_s3_decryption_fix.yaml
support: core
maintainers:

lib/ansible/plugins/action/aws_s3.py
support: core
maintainers:

Metadata

waiting_on: ansible
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 1
shipit_actors (maintainers or core team members): s-hertel
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jun 6, 2018
@ryansb ryansb merged commit 387c37e into ansible:devel Jun 6, 2018
s-hertel added a commit to s-hertel/ansible that referenced this pull request Jun 6, 2018
@s-hertel
aws_s3: don't decrypt file before uploading - fixes ansible#39287 (an…
3c52cf6 
…sible#39634)

* aws_s3: do not decrypt file before uploading to bucket

* changelog

(cherry picked from commit 387c37e)
s-hertel added a commit to s-hertel/ansible that referenced this pull request Jun 6, 2018
@s-hertel
aws_s3: don't decrypt file before uploading - fixes ansible#39287 (an…
75e4d37 
…sible#39634)

* aws_s3: do not decrypt file before uploading to bucket

* changelog

(cherry picked from commit 387c37e)
@s-hertel s-hertel mentioned this pull request Jun 6, 2018
Merged
@s-hertel s-hertel mentioned this pull request Jun 6, 2018
Merged
mattclay pushed a commit that referenced this pull request Jun 7, 2018
@s-hertel @mattclay
aws_s3: don't decrypt file before uploading - fixes #39287 (#39634)
97c6805 
* aws_s3: do not decrypt file before uploading to bucket

* changelog

(cherry picked from commit 387c37e)
nitzmahone pushed a commit that referenced this pull request Jun 8, 2018
@s-hertel @nitzmahone
aws_s3: don't decrypt file before uploading - fixes #39287 (#39634) (#…
125d1e3 
…41205)

* aws_s3: don't decrypt file before uploading - fixes #39287 (#39634)

* aws_s3: do not decrypt file before uploading to bucket

* changelog

(cherry picked from commit 387c37e)

* changelog format tweak
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@s-hertel
aws_s3: don't decrypt file before uploading - fixes ansible#39287 (an…
8a0d79a 
…sible#39634)

* aws_s3: do not decrypt file before uploading to bucket

* changelog
@ansible ansible locked and limited conversation to collaborators Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryansb ryansb ryansb approved these changes

@willthames willthames Awaiting requested review from willthames

Assignees
No one assigned
Labels
affects_2.6 This issue/PR affects Ansible v2.6 bug This issue/PR relates to a bug. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws_s3 is automaticly decrypting ansible-vault encrypted files before put
4 participants
@s-hertel @ansibot @ryansb @jborean93