Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport/2.5/39371 Issue 30786 #39660

Merged
merged 3 commits into from May 4, 2018
Merged

Backport/2.5/39371 Issue 30786 #39660

merged 3 commits into from May 4, 2018

Conversation

gtema
Copy link
Contributor

@gtema gtema commented May 3, 2018

SUMMARY

Backport fix for issue 30786

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

openstack.os_stack

ANSIBLE VERSION
ansible 2.5.1
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/gtema/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.14 (default, Mar 14 2018, 13:36:31) [GCC 7.3.1 20180303 (Red Hat 7.3.1-5)]

ADDITIONAL INFORMATION
This is a backport of the PR 39371 merged into the dev

@ansibot
Copy link
Contributor

ansibot commented May 3, 2018

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. openstack support:community This issue/PR relates to code supported by the Ansible community. labels May 3, 2018
@samdoran
Copy link
Contributor

samdoran commented May 3, 2018

Thanks for creating this backport PR. Can you also add a changelog fragment in changelog/fragments?

@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label May 3, 2018
@gtema
Copy link
Contributor Author

gtema commented May 3, 2018

done. Should it be also present in devel branch?

@gtema gtema closed this May 3, 2018
@gtema gtema reopened this May 3, 2018
@gtema
Copy link
Contributor Author

gtema commented May 3, 2018

accidentally closed the PR. After reopen check was cancelled. Is there way to restart check?
recheck?

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed community_review In order to be merged, this PR must follow the community review workflow. labels May 3, 2018
@samdoran
Copy link
Contributor

samdoran commented May 4, 2018

I'll restart the test.

The changelog fragments are relatively new, so we're not requiring them in devel yet. It's a good idea to include them in your PR to devel since it will make backporting easier, but don't worry about opening another PR just to get a changelog in devel.

@samdoran
Copy link
Contributor

samdoran commented May 4, 2018

rebuild_merge

@ansibot ansibot merged commit 81abf78 into ansible:stable-2.5 May 4, 2018
@gtema gtema deleted the backport/2.5/39371 branch May 5, 2018 15:06
@ansible ansible locked and limited conversation to collaborators May 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. openstack support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants