Use updated task, instead of original, non-merged included_file._task #39762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
bug
bcoca
approved these changes
May 4, 2018
ansibot
added
the
needs_revision
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 12, 2018
…ansible#39762) * Used updated task, instead of original, non-merged included_file._task. Fixes ansible#39637 * Add changelog entry
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 14, 2018
…ansible#39762) * Used updated task, instead of original, non-merged included_file._task. Fixes ansible#39637 * Add changelog entry
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 14, 2018
…ansible#39762) * Used updated task, instead of original, non-merged included_file._task. Fixes ansible#39637 * Add changelog entry
tonal
pushed a commit
to tonal/ansible
that referenced
this pull request
May 15, 2018
…ansible#39762) * Used updated task, instead of original, non-merged included_file._task. Fixes ansible#39637 * Add changelog entry
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 15, 2018
…ansible#39762) * Used updated task, instead of original, non-merged included_file._task. Fixes ansible#39637 * Add changelog entry
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 15, 2018
…ansible#39762) * Used updated task, instead of original, non-merged included_file._task. Fixes ansible#39637 * Add changelog entry
ilicmilan
pushed a commit
to ilicmilan/ansible
that referenced
this pull request
Nov 7, 2018
…ansible#39762) * Used updated task, instead of original, non-merged included_file._task. Fixes ansible#39637 * Add changelog entry
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Use updated task, instead of original, non-merged included_file._task. Fixes #39637
Before this change, we were using
included_file._taskin our call toget_vars. However, what is missing here, is thatincluded_file._argsaren't merged intoincluded_file._task.vars._argsis merged intovarsin_copy_included_filewhich is then later used as the parent of the new block.Use
new_block._parentinstead, which is the merged copy.ISSUE TYPE
COMPONENT NAME
lib/ansible/plugins/strategy/linear.py
ANSIBLE VERSION
ADDITIONAL INFORMATION