added initial file for v2 api of newrelic #40029

116davinder · 2018-05-11T19:15:00Z

SUMMARY

Removed Support for NewRelic V1 api for recording deployment
Added support for NewRelic V2 Api

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

newrelic_deployment

ANSIBLE VERSION

[davinderp@ansible-srv ~]$ ansible --version
ansible 2.5.2
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/davinderp/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, Nov  6 2016, 00:28:07) [GCC 4.8.5 20150623 (Red Hat 4.8.5-11)]

ADDITIONAL INFORMATION

After checking NewRelic Website, as they have depricated v1 api with xml format and they also exposed new v2 api with json/xml so i start this PR to support new v2 api and remove old version.

ansibot · 2018-05-11T19:27:46Z

cc @mcodd
click here for bot help

ansibot · 2018-05-11T19:54:53Z

The test ansible-test sanity --test pylint [explain] failed with 3 errors:

lib/ansible/modules/monitoring/newrelic_deployment.py:121:9: singleton-comparison Comparison to None should be 'expr is None'
lib/ansible/modules/monitoring/newrelic_deployment.py:125:11: singleton-comparison Comparison to None should be 'expr is None'
lib/ansible/modules/monitoring/newrelic_deployment.py:136:0: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 32 errors:

lib/ansible/modules/monitoring/newrelic_deployment.py:81:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/monitoring/newrelic_deployment.py:89:44: E202 whitespace before ')'
lib/ansible/modules/monitoring/newrelic_deployment.py:100:7: E111 indentation is not a multiple of four
lib/ansible/modules/monitoring/newrelic_deployment.py:103:7: E111 indentation is not a multiple of four
lib/ansible/modules/monitoring/newrelic_deployment.py:105:7: E111 indentation is not a multiple of four
lib/ansible/modules/monitoring/newrelic_deployment.py:107:7: E111 indentation is not a multiple of four
lib/ansible/modules/monitoring/newrelic_deployment.py:110:7: E111 indentation is not a multiple of four
lib/ansible/modules/monitoring/newrelic_deployment.py:110:11: E225 missing whitespace around operator
lib/ansible/modules/monitoring/newrelic_deployment.py:111:7: E111 indentation is not a multiple of four
lib/ansible/modules/monitoring/newrelic_deployment.py:114:30: E128 continuation line under-indented for visual indent
lib/ansible/modules/monitoring/newrelic_deployment.py:117:7: E111 indentation is not a multiple of four
lib/ansible/modules/monitoring/newrelic_deployment.py:119:7: E111 indentation is not a multiple of four
lib/ansible/modules/monitoring/newrelic_deployment.py:121:7: E111 indentation is not a multiple of four
lib/ansible/modules/monitoring/newrelic_deployment.py:121:15: E711 comparison to None should be 'if cond is None:'
lib/ansible/modules/monitoring/newrelic_deployment.py:123:7: E111 indentation is not a multiple of four
lib/ansible/modules/monitoring/newrelic_deployment.py:125:19: E711 comparison to None should be 'if cond is None:'
lib/ansible/modules/monitoring/newrelic_deployment.py:126:11: E111 indentation is not a multiple of four
lib/ansible/modules/monitoring/newrelic_deployment.py:128:7: E111 indentation is not a multiple of four
lib/ansible/modules/monitoring/newrelic_deployment.py:132:9: E225 missing whitespace around operator
lib/ansible/modules/monitoring/newrelic_deployment.py:132:11: E201 whitespace after '{'
lib/ansible/modules/monitoring/newrelic_deployment.py:132:28: E502 the backslash is redundant between brackets
lib/ansible/modules/monitoring/newrelic_deployment.py:133:25: E126 continuation line over-indented for hanging indent
lib/ansible/modules/monitoring/newrelic_deployment.py:133:69: E502 the backslash is redundant between brackets
lib/ansible/modules/monitoring/newrelic_deployment.py:134:71: E502 the backslash is redundant between brackets
lib/ansible/modules/monitoring/newrelic_deployment.py:135:75: E502 the backslash is redundant between brackets
lib/ansible/modules/monitoring/newrelic_deployment.py:136:59: W291 trailing whitespace
lib/ansible/modules/monitoring/newrelic_deployment.py:137:25: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/monitoring/newrelic_deployment.py:137:27: E502 the backslash is redundant between brackets
lib/ansible/modules/monitoring/newrelic_deployment.py:138:11: E124 closing bracket does not match visual indentation
lib/ansible/modules/monitoring/newrelic_deployment.py:145:7: E111 indentation is not a multiple of four
lib/ansible/modules/monitoring/newrelic_deployment.py:147:7: E111 indentation is not a multiple of four
lib/ansible/modules/monitoring/newrelic_deployment.py:150:3: E111 indentation is not a multiple of four

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/monitoring/newrelic_deployment.py:0:0: E105 GPLv3 license header not found in the first 20 lines of the module

click here for bot help

ansibot · 2018-05-12T12:55:25Z

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/monitoring/newrelic_deployment.py:103:0: syntax-error inconsistent use of tabs and spaces in indentation (&lt;string&gt;, line 103)

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/monitoring/newrelic_deployment.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/monitoring/newrelic_deployment.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/monitoring/newrelic_deployment.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test compile --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/monitoring/newrelic_deployment.py:103:48: SyntaxError: params["app_name"] = module.params["app_name"]

The test ansible-test sanity --test compile --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/monitoring/newrelic_deployment.py:103:48: SyntaxError: params["app_name"] = module.params["app_name"]

The test ansible-test sanity --test compile --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/monitoring/newrelic_deployment.py:103:48: SyntaxError: params["app_name"] = module.params["app_name"]

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "test/sanity/code-smell/docs-build.py", line 101, in <module>
    main()
  File "test/sanity/code-smell/docs-build.py", line 17, in main
    raise subprocess.CalledProcessError(sphinx.returncode, cmd, output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['make', 'singlehtmldocs']' returned non-zero exit status 2.

The test ansible-test sanity --test import --python 3.5 [explain] failed with 2 errors:

lib/ansible/modules/monitoring/newrelic_deployment.py:0:0: TabError: inconsistent use of tabs and spaces in indentation (newrelic_deployment.py, line 103) (in /root/ansible/test/runner/.tox/minimal-py35/bin/importer.py:82)
lib/ansible/modules/monitoring/newrelic_deployment.py:103:48: TabError: inconsistent use of tabs and spaces in indentation

The test ansible-test sanity --test import --python 3.6 [explain] failed with 2 errors:

lib/ansible/modules/monitoring/newrelic_deployment.py:0:0: TabError: inconsistent use of tabs and spaces in indentation (newrelic_deployment.py, line 103) (in /root/ansible/test/runner/.tox/minimal-py36/bin/importer.py:82)
lib/ansible/modules/monitoring/newrelic_deployment.py:103:48: TabError: inconsistent use of tabs and spaces in indentation

The test ansible-test sanity --test import --python 3.7 [explain] failed with 2 errors:

lib/ansible/modules/monitoring/newrelic_deployment.py:0:0: TabError: inconsistent use of tabs and spaces in indentation (newrelic_deployment.py, line 103) (in /root/ansible/test/runner/.tox/minimal-py37/bin/importer.py:82)
lib/ansible/modules/monitoring/newrelic_deployment.py:103:48: TabError: inconsistent use of tabs and spaces in indentation

The test ansible-test sanity --test pep8 [explain] failed with 44 errors:

lib/ansible/modules/monitoring/newrelic_deployment.py:82:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/monitoring/newrelic_deployment.py:103:1: E101 indentation contains mixed spaces and tabs
lib/ansible/modules/monitoring/newrelic_deployment.py:103:1: W191 indentation contains tabs
lib/ansible/modules/monitoring/newrelic_deployment.py:104:1: E101 indentation contains mixed spaces and tabs
lib/ansible/modules/monitoring/newrelic_deployment.py:105:5: E101 indentation contains mixed spaces and tabs
lib/ansible/modules/monitoring/newrelic_deployment.py:105:5: W191 indentation contains tabs
lib/ansible/modules/monitoring/newrelic_deployment.py:107:5: E101 indentation contains mixed spaces and tabs
lib/ansible/modules/monitoring/newrelic_deployment.py:107:5: W191 indentation contains tabs
lib/ansible/modules/monitoring/newrelic_deployment.py:110:1: E101 indentation contains mixed spaces and tabs
lib/ansible/modules/monitoring/newrelic_deployment.py:110:1: W191 indentation contains tabs
lib/ansible/modules/monitoring/newrelic_deployment.py:110:6: E225 missing whitespace around operator
lib/ansible/modules/monitoring/newrelic_deployment.py:111:1: E101 indentation contains mixed spaces and tabs
lib/ansible/modules/monitoring/newrelic_deployment.py:111:7: W191 indentation contains tabs
lib/ansible/modules/monitoring/newrelic_deployment.py:112:30: E128 continuation line under-indented for visual indent
lib/ansible/modules/monitoring/newrelic_deployment.py:113:30: E128 continuation line under-indented for visual indent
lib/ansible/modules/monitoring/newrelic_deployment.py:114:30: E128 continuation line under-indented for visual indent
lib/ansible/modules/monitoring/newrelic_deployment.py:115:30: E128 continuation line under-indented for visual indent
lib/ansible/modules/monitoring/newrelic_deployment.py:116:30: E128 continuation line under-indented for visual indent
lib/ansible/modules/monitoring/newrelic_deployment.py:117:7: E101 indentation contains mixed spaces and tabs
lib/ansible/modules/monitoring/newrelic_deployment.py:117:7: W191 indentation contains tabs
lib/ansible/modules/monitoring/newrelic_deployment.py:119:7: E101 indentation contains mixed spaces and tabs
lib/ansible/modules/monitoring/newrelic_deployment.py:119:7: W191 indentation contains tabs
lib/ansible/modules/monitoring/newrelic_deployment.py:121:7: E101 indentation contains mixed spaces and tabs
lib/ansible/modules/monitoring/newrelic_deployment.py:121:7: W191 indentation contains tabs
lib/ansible/modules/monitoring/newrelic_deployment.py:121:16: E711 comparison to None should be 'if cond is None:'
lib/ansible/modules/monitoring/newrelic_deployment.py:123:5: E101 indentation contains mixed spaces and tabs
lib/ansible/modules/monitoring/newrelic_deployment.py:123:5: W191 indentation contains tabs
lib/ansible/modules/monitoring/newrelic_deployment.py:125:23: E711 comparison to None should be 'if cond is None:'
lib/ansible/modules/monitoring/newrelic_deployment.py:128:5: E101 indentation contains mixed spaces and tabs
lib/ansible/modules/monitoring/newrelic_deployment.py:128:5: W191 indentation contains tabs
lib/ansible/modules/monitoring/newrelic_deployment.py:132:9: E225 missing whitespace around operator
lib/ansible/modules/monitoring/newrelic_deployment.py:132:11: E201 whitespace after '{'
lib/ansible/modules/monitoring/newrelic_deployment.py:132:28: E502 the backslash is redundant between brackets
lib/ansible/modules/monitoring/newrelic_deployment.py:133:25: E126 continuation line over-indented for hanging indent
lib/ansible/modules/monitoring/newrelic_deployment.py:133:69: E502 the backslash is redundant between brackets
lib/ansible/modules/monitoring/newrelic_deployment.py:134:71: E502 the backslash is redundant between brackets
lib/ansible/modules/monitoring/newrelic_deployment.py:135:75: E502 the backslash is redundant between brackets
lib/ansible/modules/monitoring/newrelic_deployment.py:137:25: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/monitoring/newrelic_deployment.py:137:27: E502 the backslash is redundant between brackets
lib/ansible/modules/monitoring/newrelic_deployment.py:138:11: E124 closing bracket does not match visual indentation
lib/ansible/modules/monitoring/newrelic_deployment.py:145:5: E101 indentation contains mixed spaces and tabs
lib/ansible/modules/monitoring/newrelic_deployment.py:145:5: W191 indentation contains tabs
lib/ansible/modules/monitoring/newrelic_deployment.py:147:5: E101 indentation contains mixed spaces and tabs
lib/ansible/modules/monitoring/newrelic_deployment.py:147:5: W191 indentation contains tabs

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/monitoring/newrelic_deployment.py:0:0: E401 Python SyntaxError while parsing module

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/monitoring/newrelic_deployment.py:103:48: python-syntax-error inconsistent use of tabs and spaces in indentation (<unknown>, line 103)

click here for bot help

ansibot · 2018-05-12T18:52:44Z

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/monitoring/newrelic_deployment.py:121:11: singleton-comparison Comparison to None should be 'expr is None'
lib/ansible/modules/monitoring/newrelic_deployment.py:125:15: singleton-comparison Comparison to None should be 'expr is None'

The test ansible-test sanity --test pep8 [explain] failed with 13 errors:

lib/ansible/modules/monitoring/newrelic_deployment.py:82:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/monitoring/newrelic_deployment.py:110:13: E225 missing whitespace around operator
lib/ansible/modules/monitoring/newrelic_deployment.py:112:30: E128 continuation line under-indented for visual indent
lib/ansible/modules/monitoring/newrelic_deployment.py:113:30: E128 continuation line under-indented for visual indent
lib/ansible/modules/monitoring/newrelic_deployment.py:114:30: E128 continuation line under-indented for visual indent
lib/ansible/modules/monitoring/newrelic_deployment.py:115:30: E128 continuation line under-indented for visual indent
lib/ansible/modules/monitoring/newrelic_deployment.py:116:30: E128 continuation line under-indented for visual indent
lib/ansible/modules/monitoring/newrelic_deployment.py:121:17: E711 comparison to None should be 'if cond is None:'
lib/ansible/modules/monitoring/newrelic_deployment.py:125:23: E711 comparison to None should be 'if cond is None:'
lib/ansible/modules/monitoring/newrelic_deployment.py:132:9: E225 missing whitespace around operator
lib/ansible/modules/monitoring/newrelic_deployment.py:133:25: E126 continuation line over-indented for hanging indent
lib/ansible/modules/monitoring/newrelic_deployment.py:137:25: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/monitoring/newrelic_deployment.py:138:10: E124 closing bracket does not match visual indentation

click here for bot help

ansibot · 2018-05-12T19:36:15Z

The test ansible-test sanity --test pep8 [explain] failed with 8 errors:

lib/ansible/modules/monitoring/newrelic_deployment.py:120:33: E127 continuation line over-indented for visual indent
lib/ansible/modules/monitoring/newrelic_deployment.py:121:33: E122 continuation line missing indentation or outdented
lib/ansible/modules/monitoring/newrelic_deployment.py:122:33: E122 continuation line missing indentation or outdented
lib/ansible/modules/monitoring/newrelic_deployment.py:123:33: E122 continuation line missing indentation or outdented
lib/ansible/modules/monitoring/newrelic_deployment.py:124:33: E127 continuation line over-indented for visual indent
lib/ansible/modules/monitoring/newrelic_deployment.py:125:33: E127 continuation line over-indented for visual indent
lib/ansible/modules/monitoring/newrelic_deployment.py:145:25: E126 continuation line over-indented for hanging indent
lib/ansible/modules/monitoring/newrelic_deployment.py:149:25: E123 closing bracket does not match indentation of opening bracket's line

click here for bot help

ansibot · 2018-05-13T04:59:01Z

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/monitoring/newrelic_deployment.py:95:9: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/monitoring/newrelic_deployment.py:146:9: E123 closing bracket does not match indentation of opening bracket's line

click here for bot help

nathanwebsterdotme · 2018-10-09T08:17:46Z

+1

nathanwebsterdotme · 2018-10-09T12:00:21Z

@ansibot ready_for_review

116davinder · 2018-11-17T17:25:56Z

anyone can merge it ?

116davinder · 2018-11-29T15:34:16Z

@ansibot ready_for_review

116davinder · 2019-02-03T20:01:27Z

@ansibot ready_for_review

Constantin07 · 2019-11-04T11:37:46Z

when this PR is going to be reviewed ? Can it be merged ?

116davinder · 2020-05-11T08:43:14Z

@Constantin07 I don't know, It has been waiting for more than 2 year and I didn't manage to find the right process as well like who should review it / who should merge it.

ansibot · 2020-08-16T14:15:39Z

Thank you very much for your interest in Ansible. Ansible has migrated much of the content into separate repositories to allow for more rapid, independent development. We are closing this issue/PR because this content has been moved to one or more collection repositories.

lib/ansible/modules/monitoring/newrelic_deployment.py -> https://galaxy.ansible.com/community/general

For further information, please see:
https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md

116davinder · 2020-09-09T09:47:50Z

created PR on New Repository:
ansible-collections/community.general#876

added initial file for v2 api of newrelic

41dda54

ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels May 11, 2018

fixed license and some of intendations

6bfdbe3

ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label May 12, 2018

fixed few more intendation issues

8ff4136

fixed all spaces issues

f097b2b

ansibot added the ci_verified Changes made in this PR are causing tests to fail. label May 12, 2018

fixed few more pep8 issues

7206fa0

ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label May 12, 2018

ansibot added the ci_verified Changes made in this PR are causing tests to fail. label May 12, 2018

116davinder added 2 commits May 13, 2018 10:12

more pep8 issues

ed82e3b

removed extra lines

73b0047

ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label May 13, 2018

ansibot added the ci_verified Changes made in this PR are causing tests to fail. label May 13, 2018

E123 closing bracket at line 95

7f02eb3

ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label May 13, 2018

ansibot removed the needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) label Nov 9, 2018

116davinder closed this Nov 17, 2018

116davinder reopened this Nov 17, 2018

ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 17, 2018

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 26, 2018

ansibot added the monitoring Monitoring category label Feb 19, 2019

ansibot added collection Related to Ansible Collections work collection:community.general needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md labels Apr 29, 2020

ansibot added the bot_closed label Aug 16, 2020

ansibot closed this Aug 16, 2020

116davinder mentioned this pull request Sep 9, 2020

Added code for NewRelic V2 ansible-collections/community.general#876

Closed

ansible locked and limited conversation to collaborators Sep 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added initial file for v2 api of newrelic #40029

added initial file for v2 api of newrelic #40029

116davinder commented May 11, 2018 •

edited

ansibot commented May 11, 2018

ansibot commented May 11, 2018

ansibot commented May 12, 2018

ansibot commented May 12, 2018

ansibot commented May 12, 2018

ansibot commented May 13, 2018

nathanwebsterdotme commented Oct 9, 2018

nathanwebsterdotme commented Oct 9, 2018

116davinder commented Nov 17, 2018

116davinder commented Nov 29, 2018

116davinder commented Feb 3, 2019

Constantin07 commented Nov 4, 2019

116davinder commented May 11, 2020

ansibot commented Aug 16, 2020

116davinder commented Sep 9, 2020

added initial file for v2 api of newrelic #40029

added initial file for v2 api of newrelic #40029

Conversation

116davinder commented May 11, 2018 • edited

SUMMARY

ISSUE TYPE

COMPONENT NAME

ANSIBLE VERSION

ADDITIONAL INFORMATION

ansibot commented May 11, 2018

ansibot commented May 11, 2018

ansibot commented May 12, 2018

ansibot commented May 12, 2018

ansibot commented May 12, 2018

ansibot commented May 13, 2018

nathanwebsterdotme commented Oct 9, 2018

nathanwebsterdotme commented Oct 9, 2018

116davinder commented Nov 17, 2018

116davinder commented Nov 29, 2018

116davinder commented Feb 3, 2019

Constantin07 commented Nov 4, 2019

116davinder commented May 11, 2020

ansibot commented Aug 16, 2020

116davinder commented Sep 9, 2020

116davinder commented May 11, 2018 •

edited