Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add copy module support for filesystems without chmod #40099

Merged
merged 1 commit into from
May 14, 2018
Merged

Add copy module support for filesystems without chmod #40099

merged 1 commit into from
May 14, 2018

Conversation

nchepanov
Copy link
Contributor

SUMMARY
  • only relevant to remote_src=True
  • separate file content copying from file stats copying
  • raise exception on mode='preserve', ignore otherwise

Fixes: #19731

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

modules/files/copy.py

ANSIBLE VERSION
ansible 2.6.0 (fix/issue19731 017a12ed25) last updated 2018/05/14 14:34:49 (GMT -400)
  config file = None
  configured module search path = [u'/Users/nchepanov/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/nchepanov/dev/ansible/ansible/lib/ansible
  executable location = /Users/nchepanov/dev/ansible/ansible/bin/ansible
  python version = 2.7.10 (default, Jul 15 2017, 17:16:57) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.31)]

Signed-off-by: Nikita Chepanov nchepanov@bloomberg.net

Add copy module support for filesystems without chmod
017a12e 
* only relevant to remote_src=True
* separate file content copying from file stats copying
* raise exception on mode='preserve', ignore otherwise

Fixes: #19731
Signed-off-by: Nikita Chepanov <nchepanov@bloomberg.net>
@ansibot ansibot added bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 14, 2018
@abadger abadger merged commit 9514a61 into ansible:devel May 14, 2018
@abadger
Copy link
Contributor

abadger commented May 14, 2018

@nikitos3000 Thanks! merged to devel for 2.6.0 release!

@user318 user318 mentioned this pull request May 14, 2018
Closed
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
@nchepanov
Add copy module support for filesystems without chmod (ansible#40099)
8443a35 
* only relevant to remote_src=True
* separate file content copying from file stats copying
* raise exception on mode='preserve', ignore otherwise

Fixes: ansible#19731
Signed-off-by: Nikita Chepanov <nchepanov@bloomberg.net>
tonal pushed a commit to tonal/ansible that referenced this pull request May 15, 2018
@nchepanov @tonal
Add copy module support for filesystems without chmod (ansible#40099)
65c5d64 
* only relevant to remote_src=True
* separate file content copying from file stats copying
* raise exception on mode='preserve', ignore otherwise

Fixes: ansible#19731
Signed-off-by: Nikita Chepanov <nchepanov@bloomberg.net>
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label May 15, 2018
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@nchepanov
Add copy module support for filesystems without chmod (ansible#40099)
49a7392 
* only relevant to remote_src=True
* separate file content copying from file stats copying
* raise exception on mode='preserve', ignore otherwise

Fixes: ansible#19731
Signed-off-by: Nikita Chepanov <nchepanov@bloomberg.net>
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@nchepanov
Add copy module support for filesystems without chmod (ansible#40099)
eb6fc3d 
* only relevant to remote_src=True
* separate file content copying from file stats copying
* raise exception on mode='preserve', ignore otherwise

Fixes: ansible#19731
Signed-off-by: Nikita Chepanov <nchepanov@bloomberg.net>
@maxamillion maxamillion mentioned this pull request Jun 11, 2018
Merged
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@nchepanov @ilicmilan
Add copy module support for filesystems without chmod (ansible#40099)
aa994c6 
* only relevant to remote_src=True
* separate file content copying from file stats copying
* raise exception on mode='preserve', ignore otherwise

Fixes: ansible#19731
Signed-off-by: Nikita Chepanov <nchepanov@bloomberg.net>
@ansible ansible locked and limited conversation to collaborators May 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

copy: do not chmod() if mode is not set
4 participants
@nchepanov @abadger @bcoca @ansibot