Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

save_snapshot_locally nxos_snapshot #40227

Merged
merged 1 commit into from May 16, 2018
Merged

save_snapshot_locally nxos_snapshot #40227

merged 1 commit into from May 16, 2018

Conversation

trishnaguha
Copy link
Member

Signed-off-by: Trishna Guha trishnaguha17@gmail.com

SUMMARY

fixes #40113
As per doc, save_snapshot_locally should be true in order to locally save snapshot created.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

modules/network/nxos/nxos_snapshot.py

ANSIBLE VERSION
devel

@trishnaguha
save_snapshot_locally nxos_snapshot
6b2b627 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@trishnaguha trishnaguha added this to Nice to have in 2.4.x Blocker List May 16, 2018
@ansibot
Copy link
Contributor

ansibot commented May 16, 2018

cc @GGabriele @mikewiebe @privateip @rahushen @rcarrillocruz
click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels May 16, 2018
@trishnaguha trishnaguha removed the needs_triage Needs a first human triage before being processed. label May 16, 2018
@trishnaguha trishnaguha mentioned this pull request May 16, 2018
Closed
@trishnaguha trishnaguha merged commit 979f1e5 into ansible:devel May 16, 2018
@trishnaguha trishnaguha deleted the nxos_snapshot_save_locally branch May 16, 2018 09:29
trishnaguha added a commit to trishnaguha/ansible that referenced this pull request May 16, 2018
@trishnaguha
save_snapshot_locally nxos_snapshot (ansible#40227)
071a9a8 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 979f1e5)
trishnaguha added a commit that referenced this pull request May 16, 2018
@trishnaguha
nxos_snapshot fix cherry-pick (#40231)
f1fc7cf 
* save_snapshot_locally nxos_snapshot (#40227)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 979f1e5)

* update changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@trishnaguha
save_snapshot_locally nxos_snapshot (ansible#40227)
de7c9eb 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@trishnaguha @ilicmilan
save_snapshot_locally nxos_snapshot (ansible#40227)
2e21648 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
No open projects
2.4.x Blocker List
Nice to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

save_snapshot_locally option in nxos_snapshot has no functionality
3 participants
@trishnaguha @ansibot @dagwieers