Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix junos_config confirm timeout issue #40238

Merged
merged 2 commits into from May 16, 2018
Merged

Fix junos_config confirm timeout issue #40238

merged 2 commits into from May 16, 2018

Conversation

ganeshrn
Copy link
Member

@ganeshrn ganeshrn commented May 16, 2018 •
edited

SUMMARY

Fixes: #39922
Confirm timeout value is an integer. The underlying ncclient API expects
it to be in string format, hence convert the integer to string before calling
commit_configuration

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

junos_config

ANSIBLE VERSION
2.5
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented May 16, 2018

cc @Qalthos @privateip
click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category owner_pr This PR is made by the module's maintainer. support:network This issue/PR relates to code supported by the Ansible Network Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. owner_pr This PR is made by the module's maintainer. labels May 16, 2018
@ganeshrn ganeshrn removed the needs_triage Needs a first human triage before being processed. label May 16, 2018
@ansibot
Copy link
Contributor

ansibot commented May 16, 2018

cc @gdpak @gundalow @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 16, 2018
@ganeshrn ganeshrn mentioned this pull request May 16, 2018
Closed
@ganeshrn ganeshrn merged commit 865f2c5 into ansible:devel May 16, 2018
@ganeshrn ganeshrn deleted the junos_confirm_commit_fix branch May 16, 2018 12:44
ganeshrn added a commit to ganeshrn/ansible that referenced this pull request May 16, 2018
@ganeshrn
Fix junos_config confirm timeout issue (ansible#40238)
aa3283c 
* Fix junos_config confirm timeout issue

* Fix unit test

* Update changelog

(cherry picked from commit 865f2c5)
@ganeshrn ganeshrn mentioned this pull request May 16, 2018
Merged
@ganeshrn
Copy link
Member Author

Cherry-pick to stable-2.5 #40255
Fix will be available in 2.5.3 version

@ganeshrn ganeshrn added this to Need CP into 2.5.3 in zzz NOT USED: Networking Bugs May 16, 2018
ganeshrn added a commit that referenced this pull request May 16, 2018
@ganeshrn
Fix junos_config confirm timeout issue (#40238) (#40255)
f5463f9 
* Fix junos_config confirm timeout issue

* Fix unit test

* Update changelog

(cherry picked from commit 865f2c5)
@ganeshrn ganeshrn moved this from Need CP into 2.5.3 to Done in zzz NOT USED: Networking Bugs May 16, 2018
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@ganeshrn
Fix junos_config confirm timeout issue (ansible#40238)
558b955 
* Fix junos_config confirm timeout issue

* Fix unit test
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@ganeshrn @ilicmilan
Fix junos_config confirm timeout issue (ansible#40238)
31362f6 
* Fix junos_config confirm timeout issue

* Fix unit test
@ansible ansible locked and limited conversation to collaborators May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
No open projects
zzz NOT USED: Networking Bugs
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ganeshrn @ansibot