Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apt: don't markmanual if apt-mark is not installed #40600

Merged
merged 2 commits into from May 23, 2018
Merged

apt: don't markmanual if apt-mark is not installed #40600

merged 2 commits into from May 23, 2018

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented May 23, 2018

SUMMARY

Fixes #40531

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

apt

ANSIBLE VERSION
2.5.3
devel
ADDITIONAL INFORMATION

@mkrizek mkrizek requested a review from resmo May 23, 2018 11:44
@mkrizek
Copy link
Contributor Author

mkrizek commented May 23, 2018

cc @ecksun

@ansibot
Copy link
Contributor

ansibot commented May 23, 2018

cc @mgwilliams
click here for bot help

@ansibot ansibot added affects_2.6 This issue/PR affects Ansible v2.6 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels May 23, 2018
@mkrizek mkrizek added this to READY TO REVIEW in CEM May 23, 2018
@resmo
Copy link
Contributor

resmo commented May 23, 2018

Fix looks good to me, probably worth considering to print a warning to the user, that "apt-mark was not found, skipping package marking"

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label May 23, 2018
@mkrizek
Copy link
Contributor Author

mkrizek commented May 23, 2018

@resmo good point, fixed 👍

resmo
resmo approved these changes May 23, 2018
View reviewed changes
Copy link
Contributor

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels May 23, 2018
@ecksun
Copy link

ecksun commented May 23, 2018

LGTM :)

@mkrizek mkrizek merged commit a3cfe0d into ansible:devel May 23, 2018
@mkrizek mkrizek deleted the 40531-apt-mark-avail branch May 23, 2018 12:43
@mkrizek mkrizek moved this from READY TO REVIEW to DONE in CEM May 23, 2018
mkrizek added a commit to mkrizek/ansible that referenced this pull request May 23, 2018
@mkrizek
apt: don't markmanual if apt-mark is not installed (ansible#40600)
e9a4c63 
* apt: don't markmanual if apt-mark is not installed

* Add warning

(cherry picked from commit a3cfe0d)
@mkrizek mkrizek mentioned this pull request May 23, 2018
Merged
gothicx pushed a commit to gothicx/ansible that referenced this pull request Jun 9, 2018
@mkrizek @gothicx
apt: don't markmanual if apt-mark is not installed (ansible#40600)
d31e552 
* apt: don't markmanual if apt-mark is not installed

* Add warning
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@mkrizek
apt: don't markmanual if apt-mark is not installed (ansible#40600)
5066844 
* apt: don't markmanual if apt-mark is not installed

* Add warning
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@mkrizek @ilicmilan
apt: don't markmanual if apt-mark is not installed (ansible#40600)
f955632 
* apt: don't markmanual if apt-mark is not installed

* Add warning
@dagwieers dagwieers added the packaging Packaging category label Mar 3, 2019
@ansible ansible locked and limited conversation to collaborators May 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo approved these changes

Assignees
No one assigned
Labels
affects_2.6 This issue/PR affects Ansible v2.6 bug This issue/PR relates to a bug. module This issue/PR relates to a module. packaging Packaging category shipit This PR is ready to be merged by Core support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
CEM
DONE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

apt module does not work without apt-mark
5 participants
@mkrizek @ansibot @resmo @ecksun @dagwieers