Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding changed option to save_when #40640

Merged
merged 2 commits into from May 24, 2018
Merged

Adding changed option to save_when #40640

merged 2 commits into from May 24, 2018

Conversation

jmighion
Copy link
Member

SUMMARY

Adding a new option save_when: changed. Saves the config if a change has been made during the execution of the module, just like aruba_config.
Fixes the deprecation version, similar to #32980.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

nxos_config

ANSIBLE VERSION
ansible 2.6.0dev0 (nxos_save_when_changed 4ac15640e9) last updated 2018/05/23 17:11:07 (GMT -700)
  config file = None
  configured module search path = [u'/Users/james/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/james/Documents/git/ansible/lib/ansible
  executable location = /Users/james/Documents/git/ansible/bin/ansible
  python version = 2.7.15 (default, May  1 2018, 16:44:08) [GCC 4.2.1 Compatible Apple LLVM 9.1.0 (clang-902.0.39.1)]

@ansibot
Copy link
Contributor

ansibot commented May 24, 2018

cc @Qalthos @ganeshrn @gdpak @gundalow @mikewiebe @privateip @rahushen @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.6 This issue/PR affects Ansible v2.6 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels May 24, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label May 24, 2018
@trishnaguha trishnaguha self-assigned this May 24, 2018
trishnaguha
trishnaguha suggested changes May 24, 2018
View reviewed changes
lib/ansible/modules/network/nxos/nxos_config.py Outdated
startup-config
startup-config. If the argument is set to I(changed), then the running-config
will only be copied to the startup-config if the task has made a change.
I(changed) was added in Ansible 2.5.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be Ansible 2.6

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Fixed in latest push.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels May 24, 2018
@trishnaguha trishnaguha merged commit d9533c3 into ansible:devel May 24, 2018
gothicx pushed a commit to gothicx/ansible that referenced this pull request Jun 9, 2018
@jmighion @gothicx
Adding changed option to save_when (ansible#40640)
561a318 
* Adding changed option to save_when

* Fixing version when changed was added.
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@jmighion
Adding changed option to save_when (ansible#40640)
770f0b0 
* Adding changed option to save_when

* Fixing version when changed was added.
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators May 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees

@trishnaguha trishnaguha

Labels
affects_2.6 This issue/PR affects Ansible v2.6 cisco Cisco technologies feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category nxos Cisco NXOS community support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jmighion @ansibot @trishnaguha @dagwieers @jborean93