New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update k8s module arguments to allow resource_definition to be a string #40730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.6
This issue/PR affects Ansible v2.6
core_review
In order to be merged, this PR must follow the core review workflow.
feature
This issue/PR relates to a feature request.
module
This issue/PR relates to a module.
needs_triage
Needs a first human triage before being processed.
support:community
This issue/PR relates to code supported by the Ansible community.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
labels
May 25, 2018
s-hertel
removed
the
needs_triage
Needs a first human triage before being processed.
label
May 25, 2018
ansibot
added
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
and removed
core_review
In order to be merged, this PR must follow the core review workflow.
labels
May 25, 2018
ansibot
added
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
labels
Jun 3, 2018
ansibot
removed
the
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
label
Jun 27, 2018
@maxamillion anyway I can rekick this build? |
kicked |
ansibot
added
core_review
In order to be merged, this PR must follow the core review workflow.
and removed
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
labels
Jun 28, 2018
@maxamillion can we backport this to 2.6? |
@fabianvf is this in 2.6.2? I get this error: When using this: - name: Remove old job
k8s:
definition: "{{ lookup('file', 'job.yaml') }}"
state: absent |
@towolf, no it was not backported |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.6
This issue/PR affects Ansible v2.6
core_review
In order to be merged, this PR must follow the core review workflow.
feature
This issue/PR relates to a feature request.
k8s
module
This issue/PR relates to a module.
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
support:community
This issue/PR relates to code supported by the Ansible community.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Allows resource_definition to be a string, if it is, attempts to yaml load it (as it would do with src). This allows the user to template multi-document yaml files and defer the loading to
k8s
, preventing the normal error thatfrom_yaml
would give you with multidocument yaml strings.Fixes #40684
ISSUE TYPE
COMPONENT NAME
k8s