Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix async for aws_s3 - fixes #40281 #40826

Merged
merged 3 commits into from
Jun 7, 2018
Merged

Fix async for aws_s3 - fixes #40281 #40826

merged 3 commits into from
Jun 7, 2018

Conversation

s-hertel
Copy link
Contributor

@s-hertel s-hertel commented May 29, 2018 •
edited
Loading

SUMMARY

Fixes #40281
Fixed the problem for me, WIP until I add tests and verify that this is backward compatible < 2.5.
Backport candidate.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/plugins/action/aws_s3.py

ANSIBLE VERSION
2.7.0dev0

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels May 29, 2018
@s-hertel s-hertel added cloud aws c:plugins/action and removed needs_triage Needs a first human triage before being processed. labels May 29, 2018
@ansibot
Copy link
Contributor

ansibot commented May 29, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/storage/glusterfs/gluster_volume.py:0:0: E322 "volume" is listed in the argument_spec, but not documented in the module

click here for bot help

@s-hertel s-hertel force-pushed the aws_s3_async branch 2 times, most recently from 25d6762 to 12bba7d Compare June 5, 2018 18:24
@ansibot
Copy link
Contributor

ansibot commented Jun 5, 2018

cc @lwade
click here for bot help

@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. test This PR relates to tests. labels Jun 5, 2018
@s-hertel s-hertel force-pushed the aws_s3_async branch 2 times, most recently from 66b1446 to 77ef546 Compare June 5, 2018 18:30
@ansibot ansibot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jun 5, 2018
@s-hertel s-hertel changed the title [WIP] Fix async for aws_s3 - fixes #40281 Fix async for aws_s3 - fixes #40281 Jun 5, 2018
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. labels Jun 5, 2018
@s-hertel
Copy link
Contributor Author

s-hertel commented Jun 6, 2018

bot_status

@ansibot
Copy link
Contributor

ansibot commented Jun 6, 2018

Components

changelogs/fragments/aws_s3_async_fix.yaml
support: core
maintainers:

lib/ansible/plugins/action/aws_s3.py
support: core
maintainers:

test/integration/targets/aws_s3/tasks/main.yml
support: core
maintainers: lwade s-hertel

Metadata

waiting_on: ansible
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 1
shipit_actors (maintainers or core team members): s-hertel
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jun 6, 2018
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 6, 2018
@ansibot ansibot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Jun 7, 2018
@s-hertel
Copy link
Contributor Author

s-hertel commented Jun 7, 2018

Rebased for the conflict but didn't modify anything.

@ryansb ryansb merged commit 89cea78 into ansible:devel Jun 7, 2018
This was referenced Jun 7, 2018
Merged
Merged
nitzmahone pushed a commit that referenced this pull request Jun 8, 2018
@s-hertel @nitzmahone
2.5 backport #40826 to fix async for aws_s3 (#41276)
fe2520a 
* cherry-picked from 89cea78 and fixed merge conflicts from restructuring the integration tests in devel

Fix async for aws_s3

Add a test that async is able to be used on aws_s3 tasks

(cherry picked from commit cef92e3)

* changelog format tweak
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@s-hertel
Fix async for aws_s3 - fixes ansible#40281 (ansible#40826)
d8aa9d0 
* Fix async for aws_s3

* Add a test that async is able to be used on aws_s3 tasks
@ansible ansible locked and limited conversation to collaborators Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryansb ryansb ryansb approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 aws bug This issue/PR relates to a bug. c:plugins/action cloud needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws_s3 no longer supports async since ansible 2.5
3 participants
@s-hertel @ansibot @ryansb