Fix ec2_ami block_device_mapping volume_size to be int in 2.5 #40938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.7
mentos1386
changed the title
mkrizek
removed
the
needs_triage
willthames
suggested changes
Jun 4, 2018
| new_item = dict_object.get(attribute) | ||
| if new_item is not None: | ||
| value = dict_object.get(attribute) | ||
| if type is not None: |
There was a problem hiding this comment.
I don't really like overriding the type builtin - can we use attribute_type as parameter or similar?
| new_item = dict_object.get(attribute) | ||
| if new_item is not None: | ||
| value = dict_object.get(attribute) |
There was a problem hiding this comment.
You're setting value exactly the same way that new_item was set. Either reuse new_item or use value instead of new_item
ansibot
added
needs_revision
renamed `type` to `attribute_type` reused `new_item` instead of creating new variable `value`
|
@willthames Fixed CR issues |
willthames
approved these changes
Jun 4, 2018
ansibot
added
committer_review
ryansb
approved these changes
Jun 4, 2018
|
@willthames is there a way for me to be informed when this is released? Also, is this going to be released for 2.5 as well? |
|
@mentos1386 not that I know of - it'll go out with 2.7 but it's definitely a candidate for backporting to 2.5 and 2.6 To use it prior to release see: http://willthames.github.io/2017/12/12/using-updated-modules-with-stable-ansible.html |
This was referenced Jun 6, 2018
|
Backport PRs created for 2.5 and 2.6 |
nitzmahone
pushed a commit
that referenced
this pull request
Jun 8, 2018
#41217) * Fix ec2_ami block_device_mapping volume_size to be int in 2.5 (#40938) * fix ec2_ami block_device_mapping size to be int * fixed cr issues renamed `type` to `attribute_type` reused `new_item` instead of creating new variable `value` (cherry picked from commit ab96a84) * changelog (cherry picked from commit e6cd727) * changelog format tweak
jacum
pushed a commit
to jacum/ansible
that referenced
this pull request
Jun 26, 2018
…e#40938) * fix ec2_ami block_device_mapping size to be int * fixed cr issues renamed `type` to `attribute_type` reused `new_item` instead of creating new variable `value`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
boto3 added type validation to many methods #28506. Similar to #18999 and #32291, the ec2_ami module didn't cast the volume_size parameter to int before passing it to boto. This was fine if the yaml used an integer value, but if a string was used (because of templating, or variable substitution mostly), a type error was raised.
This #32738 PR will make this PR obsolete. But until then, i think this is a valid fix.
ISSUE TYPE
COMPONENT NAME
ec2_ami
ANSIBLE VERSION
ADDITIONAL INFORMATION
If we have a task like this:
We will get an error that
volume_sizeisn't correct type:After applying the PR, there is no issues anymore.