fixing unstable tests -- upgraded version of rdbms

[zikalino]

SUMMARY

Upgrading version of rdbms
Reenabling PostgreSQL and MySQL tests

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

azure_rm_mysqlserver
azure_rm_mysqldatabase
azure_rm_postgresqlserver
azure_rm_postgresqldatabase

ANSIBLE VERSION

2.5

ADDITIONAL INFORMATION

[ansibot]

cc @mattclay
click here for bot help

[ansibot]

The test ansible-test sanity --test import --python 2.6 [explain] failed with 4 errors:

lib/ansible/modules/cloud/azure/azure_rm_mysqldatabase.py:98:0: ImportError: No module named azure.mgmt.rdbms.mysql
lib/ansible/modules/cloud/azure/azure_rm_mysqlserver.py:138:0: ImportError: No module named azure.mgmt.rdbms.mysql
lib/ansible/modules/cloud/azure/azure_rm_postgresqldatabase.py:98:0: ImportError: No module named azure.mgmt.rdbms.postgresql
lib/ansible/modules/cloud/azure/azure_rm_postgresqlserver.py:138:0: ImportError: No module named azure.mgmt.rdbms.postgresql

The test ansible-test sanity --test import --python 2.7 [explain] failed with 4 errors:

lib/ansible/modules/cloud/azure/azure_rm_mysqldatabase.py:98:0: ImportError: No module named azure.mgmt.rdbms.mysql
lib/ansible/modules/cloud/azure/azure_rm_mysqlserver.py:138:0: ImportError: No module named azure.mgmt.rdbms.mysql
lib/ansible/modules/cloud/azure/azure_rm_postgresqldatabase.py:98:0: ImportError: No module named azure.mgmt.rdbms.postgresql
lib/ansible/modules/cloud/azure/azure_rm_postgresqlserver.py:138:0: ImportError: No module named azure.mgmt.rdbms.postgresql

The test ansible-test sanity --test import --python 3.5 [explain] failed with 4 errors:

lib/ansible/modules/cloud/azure/azure_rm_mysqldatabase.py:98:0: ImportError: No module named 'azure'
lib/ansible/modules/cloud/azure/azure_rm_mysqlserver.py:138:0: ImportError: No module named 'azure'
lib/ansible/modules/cloud/azure/azure_rm_postgresqldatabase.py:98:0: ImportError: No module named 'azure'
lib/ansible/modules/cloud/azure/azure_rm_postgresqlserver.py:138:0: ImportError: No module named 'azure'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 4 errors:

lib/ansible/modules/cloud/azure/azure_rm_mysqldatabase.py:98:0: ModuleNotFoundError: No module named 'azure'
lib/ansible/modules/cloud/azure/azure_rm_mysqlserver.py:138:0: ModuleNotFoundError: No module named 'azure'
lib/ansible/modules/cloud/azure/azure_rm_postgresqldatabase.py:98:0: ModuleNotFoundError: No module named 'azure'
lib/ansible/modules/cloud/azure/azure_rm_postgresqlserver.py:138:0: ModuleNotFoundError: No module named 'azure'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 4 errors:

lib/ansible/modules/cloud/azure/azure_rm_mysqldatabase.py:98:0: ModuleNotFoundError: No module named 'azure'
lib/ansible/modules/cloud/azure/azure_rm_mysqlserver.py:138:0: ModuleNotFoundError: No module named 'azure'
lib/ansible/modules/cloud/azure/azure_rm_postgresqldatabase.py:98:0: ModuleNotFoundError: No module named 'azure'
lib/ansible/modules/cloud/azure/azure_rm_postgresqlserver.py:138:0: ModuleNotFoundError: No module named 'azure'

The test ansible-test sanity --test pep8 [explain] failed with 12 errors:

lib/ansible/modules/cloud/azure/azure_rm_mysqldatabase.py:97:1: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_mysqldatabase.py:102:1: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_mysqldatabase.py:103:5: E116 unexpected indentation (comment)
lib/ansible/modules/cloud/azure/azure_rm_mysqlserver.py:137:1: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_mysqlserver.py:142:1: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_mysqlserver.py:143:5: E116 unexpected indentation (comment)
lib/ansible/modules/cloud/azure/azure_rm_postgresqldatabase.py:97:1: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_postgresqldatabase.py:102:1: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_postgresqldatabase.py:103:5: E116 unexpected indentation (comment)
lib/ansible/modules/cloud/azure/azure_rm_postgresqlserver.py:137:1: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_postgresqlserver.py:142:1: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_postgresqlserver.py:143:5: E116 unexpected indentation (comment)

click here for bot help

[zikalino]

@mattclay while working on this pr i have noticed that version of msrest package installed when using ansible normally was not the same as in the test environment.
according to requirements file, the latest version should be installed, but for some reason in integration test environment version was older (i am not sure what version exactly), so i had to force latest version. do you have any idea why it could happen?

[yungezz]

what's the difference between those sku?

[yungezz]

shipit

[yuwzho]

shipit

[yungezz]

@zikalino does this need backport to stable-2.6?

[mattclay]

@zikalino CI uses a docker container which already has the Azure requirements pre-installed. Since the requirement was msrest!=0.4.15, the version installed was whatever was current when the container was last built. If there is a minimum version requirement, this must be expressed in the requirements file. It is not safe to assume the latest version will be installed.

[zikalino]

@mattclay how frequently is that Docker container updated?
Right not I have noticed that newest version of azure-common started causing problems in some modules, and seems like CI is not failing yet.

btw, could you approve this PR so we can merge?

[ansibot]

@zikalino this PR contains the following merge commits:

• fca4ee1

Please rebase your branch to remove these commits.

click here for bot help

[mattclay]

@zikalino The container isn't regularly updated. Having the requirements in the container up-to-date is simply an optimization for CI. Tests should not rely on particular requirements or versions being pre-installed.