Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick azure modules bugfix from devel branch #41073

Merged
merged 4 commits into from Jun 7, 2018
Merged

Cherry-pick azure modules bugfix from devel branch #41073

merged 4 commits into from Jun 7, 2018

Conversation

yuwzho
Copy link
Contributor

@yuwzho yuwzho commented Jun 4, 2018

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm.py

ANSIBLE VERSION
2.6.0
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jun 4, 2018

cc @haroldwongms @julienstroheker @mattclay @nitzmahone @sozercan @trstringer @tstringer @xscript @zikalino
click here for bot help

@ansibot ansibot added affects_2.6 This issue/PR affects Ansible v2.6 azure backport This PR does not target the devel branch. bug This issue/PR relates to a bug. c:inventory/contrib_script cloud core_review In order to be merged, this PR must follow the core review workflow. inventory Inventory category module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:certified This issue/PR relates to certified code. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jun 4, 2018
@yuwzho yuwzho closed this Jun 4, 2018
@yuwzho yuwzho reopened this Jun 4, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Jun 4, 2018
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jun 4, 2018
@ansibleazurebot ansibleazurebot mentioned this pull request Jun 5, 2018
Closed
@yuwzho yuwzho closed this Jun 5, 2018
@yuwzho yuwzho reopened this Jun 5, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 5, 2018
@yungezz
Copy link
Contributor

yungezz commented Jun 5, 2018

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jun 5, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed shipit This PR is ready to be merged by Core labels Jun 6, 2018
yuwzho and others added 4 commits June 7, 2018 15:07
@yuwzho
Fixes ansible#39648 azure_rm_virtualnetwork not handling DNS settings…
6f7b241 
… properly on existing virtual networks (ansible#40646)

* check nullable

* add test

* fix

* fix

(cherry picked from commit 7b98647)
@yungezz @yuwzho
add adfs_authority_url arg in azure_rm.py (ansible#41071)
b4cb2f1 
(cherry picked from commit bd34194)
@yuwzho
normalize the resource location (ansible#40802)
cc78a15 
(cherry picked from commit e6e08a0)
@yungezz @yuwzho
fix issue ansible#41081 in azure_rm_securitygroup (ansible#41123)
2d1e9ac 
* fix issue ansible#41081

* resolve comments

* fix lint

(cherry picked from commit 46eceba)
@ansibot ansibot added committer_review In order to be merged, this PR must follow the certified review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 7, 2018
@mattclay
Copy link
Member

mattclay commented Jun 7, 2018

@yuwzho The fix from #41071 is technically a feature (new argument), but since we're only on 2.6.0rc1 I'll merge it for stable-2.6. It would have been better to have this in before freeze though.

@mattclay mattclay merged commit c033739 into ansible:stable-2.6 Jun 7, 2018
@yungezz yungezz mentioned this pull request Jun 19, 2018
Closed
@ansible ansible locked and limited conversation to collaborators Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yungezz yungezz yungezz approved these changes

Assignees
No one assigned
Labels
affects_2.6 This issue/PR affects Ansible v2.6 azure backport This PR does not target the devel branch. bug This issue/PR relates to a bug. c:inventory/contrib_script cloud committer_review In order to be merged, this PR must follow the certified review workflow. inventory Inventory category module This issue/PR relates to a module. support:certified This issue/PR relates to certified code. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yuwzho @ansibot @yungezz @mattclay @bcoca