New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new module - aws_ses_email_template #41380

Open
wants to merge 3 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@wimnat
Contributor

wimnat commented Jun 11, 2018

SUMMARY

New module - aws_ses_email_template

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

aws_ses_email_template

ANSIBLE VERSION
2.6
ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jun 11, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_ses_email_template.py:131:0: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/cloud/amazon/aws_ses_email_template.py:48:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/amazon/aws_ses_email_template.py:131:1: W293 blank line contains whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_ses_email_template.py:0:0: E307 version_added should be 2.7. Currently 2.6

click here for bot help

@ansibot ansibot removed the ci_verified label Jun 18, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jun 18, 2018

@Constantin007 @Constantin07 @Deepakkothandan @Etherdaemon @Java1Guy @Lujeni @Madhura-CSI @MichaelBaydoun @Sodki @adq @akazakov @alachaum @amir343 @anryko @bekelchik @bpennypacker @brandond @carsongee @chenl87 @defunctio @dennisconrad @dkhenry @fiunchinho @fivethreeo @garethr @gunzy83 @gurumaia @hsingh @hyperized @iiibrad @infectsoldier @j-carl @jarv @Java1Guy @jimbydamonk @jmenga @joelthompson @jonhadfield @jonmer85 @joshsouza @jsdalton @jsmartin @kaczynskid @leedm777 @linuxdynasty @loia @lwade @MichaelBaydoun @michaeljs1990 @minichate @mjschultz @mmochan @nadirollo @nand0p @naslanidis @nathanwebsterdotme @nerzhul @nickball @orthanc @piontas @pjodouin @prasadkatti @psykotox @pwnall @raags @rickmendes @roadmapper @ryansydnor @scicoin-project @scottanderson42 @shepdelacreme @silviud @slapula @steynovich @tastychutney @tedder @tgerla @timmahoney @tombamford @tsiganenok @viper233 @whiter @willricardo @wilvk @zacblazic @zbal @zeekin @zimbatm

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@wimnat

This comment has been minimized.

Contributor

wimnat commented Jun 22, 2018

shipit

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jun 22, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_ses_email_template.py:56:19: E311 EXAMPLES is not valid YAML

click here for bot help

@wimnat

This comment has been minimized.

Contributor

wimnat commented Jun 22, 2018

Examples is valid yaml. Not sure how to bypass the checker on this one.

@wimnat

This comment has been minimized.

Contributor

wimnat commented Jun 29, 2018

@willthames @s-hertel hello, do you know a way to get the EXAMPLES check to pass?

@willthames

This comment has been minimized.

Contributor

willthames commented Jun 30, 2018

@wimnat I'd think it's that the docs parsing doesn't use the same YAML parser as Ansible. Using a standard YAML parser, it's clear that it's the !unsafe that's the problem:

yaml.load(EXAMPLES)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/will/Library/Python/2.7/lib/python/site-packages/yaml/__init__.py", line 71, in load
    return loader.get_single_data()
  File "/Users/will/Library/Python/2.7/lib/python/site-packages/yaml/constructor.py", line 39, in get_single_data
    return self.construct_document(node)
  File "/Users/will/Library/Python/2.7/lib/python/site-packages/yaml/constructor.py", line 48, in construct_document
    for dummy in generator:
  File "/Users/will/Library/Python/2.7/lib/python/site-packages/yaml/constructor.py", line 398, in construct_yaml_map
    value = self.construct_mapping(node)
  File "/Users/will/Library/Python/2.7/lib/python/site-packages/yaml/constructor.py", line 208, in construct_mapping
    return BaseConstructor.construct_mapping(self, node, deep=deep)
  File "/Users/will/Library/Python/2.7/lib/python/site-packages/yaml/constructor.py", line 133, in construct_mapping
    value = self.construct_object(value_node, deep=deep)
  File "/Users/will/Library/Python/2.7/lib/python/site-packages/yaml/constructor.py", line 88, in construct_object
    data = constructor(self, node)
  File "/Users/will/Library/Python/2.7/lib/python/site-packages/yaml/constructor.py", line 414, in construct_undefined
    node.start_mark)
yaml.constructor.ConstructorError: could not determine a constructor for the tag '!unsafe'
  in "<string>", line 6, column 19:
        subject_part: !unsafe "Greetings, {{ name }}!"
@wimnat

This comment has been minimized.

Contributor

wimnat commented Jun 30, 2018

I could quote it but then of course thats how the example will show which is not correct :/

@ansibot ansibot added the stale_ci label Jun 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment