/ansible

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no_log even when task_result doesn't provide key #41414

Merged
merged 2 commits into from Jun 12, 2018

Conversation

Reviewers

@dmsimard dmsimard

@achinthagunasekara achinthagunasekara

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
5 participants
@bcoca @abadger @dmsimard @achinthagunasekara @ansibot
@bcoca
Member

bcoca commented Jun 11, 2018

SUMMARY
  • now also checks task property
  • added reproducer to tests for unreachable status on item loop
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

task result

ANSIBLE VERSION
>=2.4
@bcoca
no_log even when task_result doesn't provide key 
 - now also checks task property
 - added reproducer to tests for unreachable status on item loop
8551394
test/integration/targets/no_log/no_log_local.yml
insertafter: EOF
line: "machine {{ item.machine }} login {{ item.login }} password {{ item.password }}"
loop: "{{ logins }}"
no_log: true

This comment has been minimized.

Show comment
Hide comment
@dmsimard

dmsimard Jun 11, 2018

Contributor

Should there be an assert that checks that DO_NOT_LOG_UNREACHABLE_ITEM is not in the output of the task somehow ?
Copy link
@dmsimard

dmsimard Jun 11, 2018

Contributor

Should there be an assert that checks that DO_NOT_LOG_UNREACHABLE_ITEM is not in the output of the task somehow ?

This comment has been minimized.

Show comment
Hide comment
@bcoca

bcoca Jun 11, 2018

Member

in runme.sh, it was already part of existing tests
Copy link
@bcoca

bcoca Jun 11, 2018

Member

in runme.sh, it was already part of existing tests

This comment has been minimized.

Show comment
Hide comment
@dmsimard

dmsimard Jun 11, 2018

Contributor

ah, gotcha.
Copy link
@dmsimard

dmsimard Jun 11, 2018

Contributor

ah, gotcha.

@ansibot ansibot added affects_2.7 bug needs_triage support:community support:core test labels Jun 11, 2018

@bcoca bcoca removed the needs_triage label Jun 11, 2018

@abadger

This comment has been minimized.

Show comment
Hide comment
@abadger

abadger Jun 11, 2018

Member

+1 to merge
Member

abadger commented Jun 11, 2018

+1 to merge
@abadger

This comment has been minimized.

Show comment
Hide comment
@abadger

abadger Jun 11, 2018

Member

Also needs backporting to stable-2.6, stable-2.5 and stable-2.4
Member

abadger commented Jun 11, 2018

Also needs backporting to stable-2.6, stable-2.5 and stable-2.4

@ansibot ansibot added the shipit label Jun 11, 2018

@abadger

This comment has been minimized.

Show comment
Hide comment
@abadger

abadger Jun 12, 2018

Member

Hmm,.. this does need a change log fragment, though. (Which will make backporting to 2.6 and 2.5 easier but will have to be changed for 2.4)
Member

abadger commented Jun 12, 2018

Hmm,.. this does need a change log fragment, though. (Which will make backporting to 2.6 and 2.5 easier but will have to be changed for 2.4)

@ansibot ansibot added needs_revision and removed shipit labels Jun 12, 2018

@abadger

This comment has been minimized.

Show comment
Hide comment
@abadger

abadger Jun 12, 2018

Member

The unstable test result is unrelated merging and openin backports.
Member

abadger commented Jun 12, 2018

The unstable test result is unrelated merging and openin backports.

@abadger abadger merged commit 5fdd101 into ansible:devel Jun 12, 2018
1 check failed

1 check failed

Shippable Run 69668 status is UNSTABLE.
Details

@bcoca bcoca deleted the bcoca:no_log_fail branch Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment