no_log even when task_result doesn't provide key #41414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- now also checks task property - added reproducer to tests for unreachable status on item loop
dmsimard
reviewed
Jun 11, 2018
| insertafter: EOF | ||
| line: "machine {{ item.machine }} login {{ item.login }} password {{ item.password }}" | ||
| loop: "{{ logins }}" | ||
| no_log: true |
There was a problem hiding this comment.
Should there be an assert that checks that DO_NOT_LOG_UNREACHABLE_ITEM is not in the output of the task somehow ?
There was a problem hiding this comment.
in runme.sh, it was already part of existing tests
ansibot
added
affects_2.7
bcoca
removed
the
needs_triage
|
+1 to merge |
|
Also needs backporting to stable-2.6, stable-2.5 and stable-2.4 |
achinthagunasekara
approved these changes
Jun 11, 2018
|
Hmm,.. this does need a change log fragment, though. (Which will make backporting to 2.6 and 2.5 easier but will have to be changed for 2.4) |
ansibot
added
needs_revision
|
The unstable test result is unrelated merging and openin backports. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ISSUE TYPE
COMPONENT NAME
task result
ANSIBLE VERSION