To fix eos_vrf failure when transport method is eapi #41470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.7
Qalthos
suggested changes
Jun 13, 2018
| @@ -189,7 +189,7 @@ def map_obj_to_commands(updates, module): | |||
|
|
|||
| def map_config_to_obj(module): | |||
| objs = [] | |||
| output = run_commands(module, ['show vrf']) | |||
| output = run_commands(module, ['show vrf | text']) | |||
There was a problem hiding this comment.
Rather than creating something not supported by the device which will inevitably confuse someone later, you should probably do run_commands(module, {'command': 'show vrf', 'output': 'text'})
There was a problem hiding this comment.
Yep.. makes sense, I have updated the code accordingly.
ansibot
added
needs_revision
|
@justjais this PR contains the following merge commits: Please rebase your branch to remove these commits. |
ansibot
added
merge_commit
ansibot
removed
merge_commit
Qalthos
suggested changes
Jun 20, 2018
| @@ -409,7 +409,10 @@ def is_eapi(module): | |||
|
|
|||
|
|
|||
| def to_command(module, commands): | |||
| if is_eapi(module): | |||
| if isinstance(commands, dict): | |||
There was a problem hiding this comment.
transform(to_list(commands)) already does this, with the bonus of not breaking if output is not specified in the dictionary. You should not have to change this file for this to work.
There was a problem hiding this comment.
Sorry, my bad I'll revert the change and will upload again
ansibot
removed
the
support:core
Qalthos
approved these changes
Jun 20, 2018
ansibot
added
core_review
justjais
added a commit
to justjais/ansible
that referenced
this pull request
Jun 21, 2018
* resolve bug 40930 * resolve bug 40930 * to fix review comments * to fix review comments * reverting the changes based on review (cherry picked from commit c989b62)
jacum
pushed a commit
to jacum/ansible
that referenced
this pull request
Jun 26, 2018
* resolve bug 40930 * resolve bug 40930 * to fix review comments * to fix review comments * reverting the changes based on review
kbreit
pushed a commit
to kbreit/ansible
that referenced
this pull request
Jul 3, 2018
…nsible#41771) * To fix eos_vrf failure when transport method is eapi (ansible#41470) * resolve bug 40930 * resolve bug 40930 * to fix review comments * to fix review comments * reverting the changes based on review (cherry picked from commit c989b62) * adding changelog for backport
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR is raised to resolve
eos_vrffailure when the transport method iseapi, and this issue was raised in bug #40930ISSUE TYPE
COMPONENT NAME
eos
ANSIBLE VERSION
ADDITIONAL INFORMATION