Allow fuse type mounts without :/ in device string

[DBezemer]

SUMMARY

Allow fuse type mounts in the gathered mount information when not matching traditional formatting with ":/"

Fixes #41494

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

setup

ANSIBLE VERSION

ansible 2.5.3
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /bin/ansible
  python version = 2.7.5 (default, Feb 20 2018, 09:19:12) [GCC 4.8.5 20150623 (Red Hat 4.8.5-28)]

[abadger]

We talked about this today and think that this PR will fix the bug but it has the potential to hang, timeout, and then lose information about any mounts that would have come afterwards. We think we have a strategy that you could implement to address that.

• In get_mount_facts() there is a for loop which loops over every mounted filesystem: https://github.com/ansible/ansible/pull/41502/files#diff-b2db09772e4a22e4ab5b8de4c3b6d11eR454
• Pull the code from inside that for loop into a helper method.
• Use the timeout decorator on the helper method instead of get_mount_facts().

The ramifications of doing that will be:

• One mount that timeouts will not break gathering facts for other mounts
• The total potential timeout period will be longer. Instead of being one timeout that covers loading all of the mounts it will be the sum of timeouts for each mount point.

[bcoca]

quick draft of proposed solution #49398

[samdoran]

Rather than continuing to make this conditional more complex, I suggest making a filter function to encapsulate this logic. Then the list of mtab_entries can be filtered before looping.

filtered_mtab_entries = (e for e in mtab_entries if _filter_mtab_entries(e))

Or the filter() built-in could be used rather than a generator:

filtered_mtab_entries = filter(_filter_mtab_entries, mtab_entries)

[s-hertel]

@DBezemer Are you able to update this PR?

needs_info

[DBezemer]

@s-hertel I will not be able to work on this PR.

[bcoca]

related #24644

[jborean93]

Closing due to extra requirements by #41502 (comment) to handle things like hangs and the original author is unable to continue with the PR.