Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nxos_linkagg issue #41550

Merged
merged 2 commits into from Jun 16, 2018
Merged

fix nxos_linkagg issue #41550

merged 2 commits into from Jun 16, 2018

Conversation

saichint
Copy link
Contributor

@saichint saichint commented Jun 14, 2018 •
edited

SUMMARY

Fixes #41547

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nxos_linkagg

ANSIBLE VERSION
ansible 2.6.0.dev0 (stable-2.6 9ae2050e2f) last updated 2018/06/11 12:10:05 (GMT -400)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /root/agents-ci/ansible/lib/ansible
  executable location = /root/agents-ci/ansible/bin/ansible
  python version = 2.7.6 (default, Oct 26 2016, 20:30:19) [GCC 4.8.4]
ADDITIONAL INFORMATION
<?xml version="1.0" encoding="ISO-8859-1"?>
<nf:rpc-reply xmlns:nf="urn:ietf:params:xml:ns:netconf:base:1.0" xmlns="http://www.cisco.com/nxos:1.0:eth_pcm_dc3">
 <nf:data/>
</nf:rpc-reply>
]]>]]>

On all other platforms, there is no output, so it works ok. On old platforms, this is causing TypeError which results in the failure.

@ansibot
Copy link
Contributor

ansibot commented Jun 14, 2018

cc @mikewiebe @privateip @rahushen @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. labels Jun 14, 2018
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Jun 15, 2018
@trishnaguha trishnaguha merged commit 119e6d6 into ansible:devel Jun 16, 2018
@trishnaguha trishnaguha self-assigned this Jun 16, 2018
trishnaguha pushed a commit to trishnaguha/ansible that referenced this pull request Jun 16, 2018
@trishnaguha
fix nxos_linkagg issue (ansible#41550)
f1ffcf6 
* fix nxos_linkagg issue

* fix shippable

(cherry picked from commit 119e6d6)
trishnaguha pushed a commit to trishnaguha/ansible that referenced this pull request Jun 16, 2018
@trishnaguha
fix nxos_linkagg issue (ansible#41550)
001c383 
* fix nxos_linkagg issue

* fix shippable

(cherry picked from commit 119e6d6)
@saichint saichint deleted the linkagg branch June 18, 2018 16:24
mattclay pushed a commit that referenced this pull request Jun 18, 2018
@mattclay
fix nxos_linkagg issue (#41550)
3278ef4 
* fix nxos_linkagg issue

* fix shippable

(cherry picked from commit 119e6d6)
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
fix nxos_linkagg issue (ansible#41550)
c91f6b0 
* fix nxos_linkagg issue

* fix shippable
nitzmahone pushed a commit that referenced this pull request Jul 3, 2018
@trishnaguha @nitzmahone
fix nxos_linkagg issue (#41550) (#41620)
15ac94f 
* fix nxos_linkagg issue (#41550)

* fix nxos_linkagg issue

* fix shippable

(cherry picked from commit 119e6d6)

* changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Jun 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@achinthagunasekara achinthagunasekara achinthagunasekara approved these changes

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees

@trishnaguha trishnaguha

Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
No open projects
zzz NOT USED: Networking Bugs
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nxos_linkagg fails to create linkagg when running on I2 image
6 participants
@saichint @ansibot @achinthagunasekara @trishnaguha @dagwieers @mkrizek