Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort the port list properly (.sort() returns None) #41567

Merged
merged 1 commit into from
Jun 15, 2018
Merged

sort the port list properly (.sort() returns None) #41567

merged 1 commit into from
Jun 15, 2018

Conversation

schp
Copy link
Contributor

@schp schp commented Jun 14, 2018

SUMMARY

Sort the list of ports properly. The sort function sorts the list in place and returns None, which was surely not the intended effect.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

gce_net

ANSIBLE VERSION
ansible 2.5.4
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/sp/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/dist-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.15rc1 (default, Apr 15 2018, 21:51:34) [GCC 7.3.0]

@ansibot
Copy link
Contributor

ansibot commented Jun 14, 2018

cc @erjohnso @rambleraptor @supertom
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. gce module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. labels Jun 14, 2018
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Jun 15, 2018
@abadger abadger merged commit 63f2ad8 into ansible:devel Jun 15, 2018
abadger added a commit to abadger/ansible that referenced this pull request Jun 15, 2018
@abadger
Add changelog for gce_net sort fix
a386d01 
ansible#41567
@abadger abadger mentioned this pull request Jun 15, 2018
Merged
abadger added a commit that referenced this pull request Jun 16, 2018
@abadger
Add changelog for gce_net sort fix
ad8142f 
#41567
abadger added a commit to abadger/ansible that referenced this pull request Jun 18, 2018
@abadger
[stable-2.6] Add changelog for gce_net sort fix
83c7175 
ansible#41567
(cherry picked from commit ad8142f)

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
@abadger abadger mentioned this pull request Jun 18, 2018
Merged
mattclay pushed a commit that referenced this pull request Jun 18, 2018
@abadger @mattclay
[stable-2.6] Add changelog for gce_net sort fix
d66dc0d 
#41567
(cherry picked from commit ad8142f)

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@abadger
Add changelog for gce_net sort fix
973c098 
ansible#41567
@ansible ansible locked and limited conversation to collaborators Jun 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. gce module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@schp @ansibot @abadger @Akasurde