exclude lookup_terms from config errors #41740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.7
bcoca
removed
the
needs_triage
|
I can confirm at minimum that this resolves #41696 |
ansibot
added
the
needs_revision
s-hertel
reviewed
Jun 20, 2018
There was a problem hiding this comment.
I'm getting weird behavior for required options in lookups but it doesn't seem like it's due to this. Also doesn't appear that any plugins are broken by it at the moment.
diff --git a/lib/ansible/plugins/lookup/vars.py b/lib/ansible/plugins/lookup/vars.py
index 9ce5d30467..8119f110f1 100644
--- a/lib/ansible/plugins/lookup/vars.py
+++ b/lib/ansible/plugins/lookup/vars.py
@@ -18,6 +18,9 @@ DOCUMENTATION = """
description:
- What to return if a variable is undefined.
- If no default is set, it will result in an error if any of the variables is undefined.
+ test_req_options:
+ description: test required options
+ required: true
with or without the required option outputs
$ ansible -m debug -a msg="{{ lookup('vars', 'foobar', default='ok', test_req_options='test') }}" -c local localhost
[WARNING]: provided hosts list is empty, only localhost is available. Note that the implicit localhost does not match 'all'
localhost | FAILED! => {
"msg": "An unhandled exception occurred while running the lookup plugin 'vars'. Error was a <class 'ansible.errors.AnsibleError'>, original message: Invalid settings supplied for test_req_options: No setting was provided for required configuration plugin_type: lookup plugin: vars setting: test_req_options "
}
(Actually, looks like on devel required: True just might be ignored for lookup plugins right now?)
lib/ansible/config/manager.py
Outdated
| @@ -365,7 +366,8 @@ def get_config_value_and_origin(self, config, cfile=None, plugin_type=None, plug | |||
| if plugin_name: | |||
| entry += 'plugin: %s ' % plugin_name | |||
| entry += 'setting: %s ' % config | |||
| raise AnsibleError("No setting was provided for required configuration %s" % (entry)) | |||
| if not plugin_type or config not in INTERNAL_DEFS.get(plugin_type): | |||
There was a problem hiding this comment.
INTERNAL_DEFS.get(plugin_type, ()) since Nonetype isn't iterable
There was a problem hiding this comment.
i don't get that error, weird since it is defined on top in same file .... and plugin_type is not used if None
There was a problem hiding this comment.
I got that error using an inventory plugin, not a lookup.
|
the other behaviour is because of how i pass 'direct' ... its a bug |
|
try now, that should fix 'direct processing' |
s-hertel
reviewed
Jun 20, 2018
lib/ansible/config/manager.py
Outdated
| if plugin_name: | ||
| entry += 'plugin: %s ' % plugin_name | ||
| entry += 'setting: %s ' % config | ||
| if not plugin_type or config not in INTERNAL_DEFS.get(plugin_type): |
There was a problem hiding this comment.
Causes unhelpful error if get() returns None
$ cat nmap_inv.yml
plugin: nmap
$ ansible-inventory -i nmap_inv.yml --graph
ERROR! Invalid settings supplied for address: argument of type 'NoneType' is not iterable
There was a problem hiding this comment.
ah, misunderstood your prev comment
|
Looks good to me, shipit |
ansibot
added
shipit
bcoca
added a commit
to bcoca/ansible
that referenced
this pull request
Jun 21, 2018
* exclude lookup_terms from config errors * moved direct (cherry picked from commit 0102e42)
mattclay
pushed a commit
that referenced
this pull request
Jun 22, 2018
* exclude lookup_terms from config errors * moved direct (cherry picked from commit 0102e42)
jacum
pushed a commit
to jacum/ansible
that referenced
this pull request
Jun 26, 2018
* exclude lookup_terms from config errors * moved direct
kbreit
pushed a commit
to kbreit/ansible
that referenced
this pull request
Jul 3, 2018
* exclude lookup_terms from config errors * moved direct (cherry picked from commit 0102e42)
This was referenced Jul 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ISSUE TYPE
COMPONENT NAME
config
plugins/lookup
ANSIBLE VERSION