Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple var files combining (followup to #36357) #41761

Merged
merged 1 commit into from Jul 20, 2018

Conversation

andriilahuta
Copy link
Contributor

SUMMARY

Fix multiple var files combining (followup to #36357)

When defaults/main or vars/main is a directory, then only the first file gets loaded. This PR fixes that.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vars loading

ANSIBLE VERSION

ansible 2.7.0.dev0 (role_defaults_vars_dirs f94f32d449) last updated 2018/06/20 23:49:34 (GMT +300)

ADDITIONAL INFORMATION

N/A

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 20, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Jun 21, 2018
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jun 27, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 5, 2018
@andriilahuta
Copy link
Contributor Author

Affects 2.6 as well.

@bcoca bcoca requested a review from agaffney July 20, 2018 00:59
@bcoca bcoca merged commit 2e62e36 into ansible:devel Jul 20, 2018
@bcoca
Copy link
Member

bcoca commented Jul 20, 2018

@andriilahuta andriilahuta deleted the role_defaults_vars_dirs branch July 27, 2018 02:36
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. new_contributor This PR is the first contribution by a new community member. small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants