Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't import password lookup from network filters #41907

Merged
merged 1 commit into from
Jun 25, 2018
Merged

Don't import password lookup from network filters #41907

merged 1 commit into from
Jun 25, 2018

Conversation

sivel
Copy link
Member

@sivel sivel commented Jun 25, 2018

SUMMARY

Don't import password lookup from network filters. Fixes #41874

This ensures we don't load the password lookup outside of the plugin loader, allowing custom lookups with the same name as a built in to function.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/plugins/filter/network.py

ANSIBLE VERSION
2.6
2.7
ADDITIONAL INFORMATION

@sivel sivel mentioned this pull request Jun 25, 2018
Closed
@ansibot
Copy link
Contributor

ansibot commented Jun 25, 2018

cc @Qalthos @ganeshrn @gdpak @gundalow @privateip @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 25, 2018
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jun 25, 2018
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jun 25, 2018
@sivel sivel merged commit 9353742 into ansible:devel Jun 25, 2018
sivel added a commit to sivel/ansible that referenced this pull request Jun 25, 2018
@sivel
Don't import password lookup from network filters. Fixes ansible#41874 (
28871d7 
ansible#41907)

(cherry picked from commit 9353742)
sivel added a commit to sivel/ansible that referenced this pull request Jun 25, 2018
@sivel
Add changelog for ansible#41907
cd56dce
@sivel sivel mentioned this pull request Jun 25, 2018
Merged
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@sivel
Don't import password lookup from network filters. Fixes ansible#41874 (
0f294b4 
ansible#41907)
mattclay pushed a commit that referenced this pull request Jun 26, 2018
@sivel @mattclay
Backport #41907 for 2.6 - fix password lookup loading (#41928)
c15f99f 
* Don't import password lookup from network filters. Fixes #41874 (#41907)

(cherry picked from commit 9353742)

* Add changelog for #41907
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jul 3, 2018
@sivel @kbreit
Backport ansible#41907 for 2.6 - fix password lookup loading (ansible…
ea80a38 
…#41928)

* Don't import password lookup from network filters. Fixes ansible#41874 (ansible#41907)

(cherry picked from commit 9353742)

* Add changelog for ansible#41907
@ansible ansible locked and limited conversation to collaborators Jun 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bcoca bcoca bcoca approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot load custom lookup plugin
3 participants
@sivel @ansibot @bcoca