Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

options should be settable multiple times #41913

Merged
merged 1 commit into from
Jun 26, 2018
Merged

options should be settable multiple times #41913

merged 1 commit into from
Jun 26, 2018

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Jun 25, 2018

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

config

ANSIBLE VERSION
2.6

@bcoca bcoca mentioned this pull request Jun 25, 2018
Merged
@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 25, 2018
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jun 25, 2018
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jun 25, 2018
@pilou-
Copy link
Contributor

pilou- commented Jun 26, 2018

LGTM (manually tested using 31936ce)

The drawback is that ConfigManager.get_configuration_definitions() will be called twice, but for 2.6, this fix would do the job.

@s-hertel
Copy link
Contributor

Ran into this today in a couple of places. I guess the aliases for the aws_ec2_inventory weren't running on general pull requests to modify config - those are failing locally for me. Removed my change to lib/ansible/plugins/__init__.py on #41919 and cherry-picked this commit to test. Also tested with the aws_ec2_inventory target. LGTM.

@pilou- pilou- mentioned this pull request Jun 26, 2018
Closed
@bcoca bcoca merged commit 27e3cd6 into ansible:devel Jun 26, 2018
@bcoca bcoca deleted the fix_options branch June 26, 2018 14:23
@pilou- pilou- mentioned this pull request Jun 28, 2018
Closed
@ansible ansible locked and limited conversation to collaborators Jun 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bcoca @pilou- @s-hertel @ansibot