WIP: npm module: added "options" argument

[tmshn]

SUMMARY

npm command provides many options such as save, package-lock and ignore-scripts.
Although some options are supported by the module arguments, still there are many options not supported.

Rather than implementing arguments for each of them, I added options argument to support them all.

Usage example:

- name: install node modules without editing package.json
  npm:
    path: '{{ repo.path }}'
    options:
      save: no

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

npm module

ANSIBLE VERSION

ansible 2.7.0.dev0 (npm-options ea38792fb2) last updated 2018/06/30 23:38:02 (GMT +900)
  config file = None
  configured module search path = [u'/Users/01014505/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/01014505/Documents/dev/oss/ansible/lib/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.15 (default, May  1 2018, 16:44:14) [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.42.1)]

[ansibot]

cc @shane-walker @xcambar
click here for bot help

[ansibot]

The test ansible-test sanity --test pylint [explain] failed with 3 errors:

lib/ansible/modules/packaging/language/npm.py:181:27: undefined-variable Undefined variable 'v'
lib/ansible/modules/packaging/language/npm.py:182:23: undefined-variable Undefined variable 'v'
lib/ansible/modules/packaging/language/npm.py:183:16: ansible-format-automatic-specification Format string contains automatic field numbering specification

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/packaging/language/npm.py:149:5: E271 multiple spaces after keyword
lib/ansible/modules/packaging/language/npm.py:179:9: E306 expected 1 blank line before a nested definition, found 0

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/packaging/language/npm.py:0:0: E305 DOCUMENTATION.options.options.type: not a valid value for dictionary value @ data['options']['options']['type']. Got 'dict'
lib/ansible/modules/packaging/language/npm.py:0:0: E309 version_added for new option (options) should be 2.7. Currently 0.0

click here for bot help

[ansibot]

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/packaging/language/npm.py:152:1: E302 expected 2 blank lines, found 1

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/packaging/language/npm.py:0:0: E305 DOCUMENTATION.options.options.type: not a valid value for dictionary value @ data['options']['options']['type']. Got 'dict'

click here for bot help

[ansibot]

The test ansible-test sanity --test no-underscore-variable [explain] failed with 1 error:

lib/ansible/modules/packaging/language/npm.py:229:13: use `dummy` instead of `_` for a variable name

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/packaging/language/npm.py:0:0: E305 DOCUMENTATION.options.options.type: not a valid value for dictionary value @ data['options']['options']['type']. Got 'dict'

click here for bot help

[ansibot]

The test ansible-test sanity --test no-underscore-variable [explain] failed with 1 error:

lib/ansible/modules/packaging/language/npm.py:228:13: use `dummy` instead of `_` for a variable name

click here for bot help

[ansibot]

Thank you very much for your interest in Ansible. Ansible has migrated much of the content into separate repositories to allow for more rapid, independent development. We are closing this issue/PR because this content has been moved to one or more collection repositories.

• lib/ansible/modules/packaging/language/npm.py -> https://galaxy.ansible.com/community/general
• test/integration/targets/npm/tasks/test.yml -> https://galaxy.ansible.com/community/general

For further information, please see:
https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md