Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for global IGMP configuration on onyx switches #42164

Merged
merged 2 commits into from Jul 18, 2018

Conversation

samerd
Copy link
Contributor

@samerd samerd commented Jul 1, 2018

Signed-off-by: Samer Deeb samerd@mellanox.com

SUMMARY

Add support for configuring global parameters of IGMP protocol on ONYX network devices

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

onyx_igmp.py

ANSIBLE VERSION
ansible 2.5.5
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, May  3 2017, 07:55:04) [GCC 4.8.5 20150623 (Red Hat 4.8.5-14)]
ADDITIONAL INFORMATION

Signed-off-by: Samer Deeb <samerd@mellanox.com>
@ansibot
Copy link
Contributor

ansibot commented Jul 1, 2018

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Jul 1, 2018
@ansibot
Copy link
Contributor

ansibot commented Jul 1, 2018

The test ansible-test sanity --test docs-build [explain] failed with 2 errors:

docs/docsite/rst/modules/list_of_all_modules.rst:1258:0: undefined-label: undefined label: onyx_igmp_module (if the link has no caption the label must precede a section header)
docs/docsite/rst/modules/list_of_network_modules.rst:938:0: undefined-label: undefined label: onyx_igmp_module (if the link has no caption the label must precede a section header)

The test ansible-test sanity --test validate-modules [explain] failed with 9 errors:

lib/ansible/modules/network/onyx/onyx_igmp.py:0:0: E305 DOCUMENTATION.module: not a valid value for dictionary value @ data['module']. Got 'onyx_bgp'
lib/ansible/modules/network/onyx/onyx_igmp.py:0:0: E307 version_added should be 2.7. Currently 2.6
lib/ansible/modules/network/onyx/onyx_igmp.py:0:0: E324 Value for "default" from the argument_spec (None) for "default_version" does not match the documentation ('V3')
lib/ansible/modules/network/onyx/onyx_igmp.py:0:0: E324 Value for "default" from the argument_spec (None) for "last_member_query_interval" does not match the documentation (1)
lib/ansible/modules/network/onyx/onyx_igmp.py:0:0: E324 Value for "default" from the argument_spec (None) for "mrouter_timeout" does not match the documentation (125)
lib/ansible/modules/network/onyx/onyx_igmp.py:0:0: E324 Value for "default" from the argument_spec (None) for "port_purge_timeout" does not match the documentation (260)
lib/ansible/modules/network/onyx/onyx_igmp.py:0:0: E324 Value for "default" from the argument_spec (None) for "proxy_reporting" does not match the documentation ('enabled')
lib/ansible/modules/network/onyx/onyx_igmp.py:0:0: E324 Value for "default" from the argument_spec (None) for "report_suppression_interval" does not match the documentation (5)
lib/ansible/modules/network/onyx/onyx_igmp.py:0:0: E324 Value for "default" from the argument_spec (None) for "unregistered_multicast" does not match the documentation ('flood')

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 1, 2018
Signed-off-by: Samer Deeb <samerd@mellanox.com>
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 1, 2018
@ryansb ryansb removed the needs_triage Needs a first human triage before being processed. label Jul 3, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 11, 2018
@gundalow
Copy link
Contributor

rebuild_merge

@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jul 18, 2018
@ansibot ansibot merged commit 3ca4a35 into ansible:devel Jul 18, 2018
@gundalow
Copy link
Contributor

Merged into devel for release in Ansible 2.7

@samerd
Copy link
Contributor Author

samerd commented Jul 19, 2018

@gundalow : thanks a lot for the merge

@samerd samerd deleted the feature/igmp branch August 22, 2018 19:34
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.7 This issue/PR affects Ansible v2.7 core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants