Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defined netapp_e_syslog storage module #42421

Merged
merged 1 commit into from Aug 28, 2018
Merged

Defined netapp_e_syslog storage module #42421

merged 1 commit into from Aug 28, 2018

Conversation

ndswartz
Copy link
Contributor

@ndswartz ndswartz commented Jul 6, 2018

SUMMARY

Module allows syslog server configuration on NetApp E-Series storage arrays.

This patch also add integration and unit tests.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

netapp_e_syslog

ANSIBLE VERSION
  config file = None
  configured module search path = [u'/home/swartzn/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/swartzn/ansible/lib/ansible
  executable location = /home/swartzn/ansible/bin/ansible
  python version = 2.7.15rc1 (default, Apr 15 2018, 21:51:34) [GCC 7.3.0]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jul 6, 2018

cc @amit0701 @carchi8py @hulquest @lmprice @schmots1
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. netapp new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. storage support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Jul 6, 2018
@ansibot
Copy link
Contributor

ansibot commented Jul 6, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_syslog.py:0:0: E325 argument_spec for "validate_certs" defines type="bool" but documentation does not

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 6, 2018
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Jul 6, 2018
@ansibot
Copy link
Contributor

ansibot commented Jul 6, 2018

cc @mattclay
click here for bot help

@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jul 6, 2018
@ansibot
Copy link
Contributor

ansibot commented Jul 6, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 16 errors:

lib/ansible/modules/cloud/lxc/lxc_container.py:577:9: E210 subprocess.Popen call found. Should be module.run_command
lib/ansible/modules/database/mysql/mysql_db.py:223:14: E210 subprocess.Popen call found. Should be module.run_command
lib/ansible/modules/database/mysql/mysql_db.py:224:14: E210 subprocess.Popen call found. Should be module.run_command
lib/ansible/modules/database/postgresql/postgresql_db.py:308:14: E210 subprocess.Popen call found. Should be module.run_command
lib/ansible/modules/database/postgresql/postgresql_db.py:309:14: E210 subprocess.Popen call found. Should be module.run_command
lib/ansible/modules/packaging/os/flatpak.py:197:15: E210 subprocess.Popen call found. Should be module.run_command
lib/ansible/modules/packaging/os/flatpak_remote.py:162:15: E210 subprocess.Popen call found. Should be module.run_command
lib/ansible/modules/system/service.py:257:17: E210 subprocess.Popen call found. Should be module.run_command
test/sanity/validate-modules/ignore.txt:684:1: A102 Remove since "lib/ansible/modules/network/aci/aci_bd_subnet.py" passes "E328" test
test/sanity/validate-modules/ignore.txt:685:1: A102 Remove since "lib/ansible/modules/network/aci/aci_config_snapshot.py" passes "E328" test
test/sanity/validate-modules/ignore.txt:686:1: A102 Remove since "lib/ansible/modules/network/aci/aci_epg_to_domain.py" passes "E326" test
test/sanity/validate-modules/ignore.txt:687:1: A102 Remove since "lib/ansible/modules/network/aci/aci_epg_to_domain.py" passes "E328" test
test/sanity/validate-modules/ignore.txt:688:1: A102 Remove since "lib/ansible/modules/network/aci/aci_filter_entry.py" passes "E326" test
test/sanity/validate-modules/ignore.txt:692:1: A102 Remove since "lib/ansible/modules/network/aci/aci_interface_policy_port_channel.py" passes "E328" test
test/sanity/validate-modules/ignore.txt:693:1: A102 Remove since "lib/ansible/modules/network/aci/aci_static_binding_to_epg.py" passes "E328" test
test/sanity/validate-modules/ignore.txt:923:1: A102 Remove since "lib/ansible/modules/network/nxos/nxos_nxapi.py" passes "E324" test

click here for bot help

mattclay
mattclay reviewed Jul 6, 2018
View reviewed changes
test/sanity/validate-modules/ignore.txt Outdated
@@ -251,7 +251,6 @@ lib/ansible/modules/cloud/linode/linode.py E322
lib/ansible/modules/cloud/linode/linode.py E324
lib/ansible/modules/cloud/lxc/lxc_container.py E324
lib/ansible/modules/cloud/lxc/lxc_container.py E326
lib/ansible/modules/cloud/lxc/lxc_container.py E210
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the changes to this file appear to be unrelated to the PR.

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Jul 6, 2018
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jul 7, 2018
@ndswartz ndswartz closed this Jul 9, 2018
@ndswartz ndswartz reopened this Jul 9, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 9, 2018
lmprice
lmprice approved these changes Jul 9, 2018
View reviewed changes
Copy link
Contributor

@lmprice lmprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 9, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed shipit This PR is ready to be merged by Core core_review In order to be merged, this PR must follow the core review workflow. labels Aug 23, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 23, 2018
@swartzn
Defined netapp_e_syslog storage module
49d6d80 
Module allows syslog server configuration on NetApp E-Series storage arrays.
@ansibot
Copy link
Contributor

ansibot commented Aug 24, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_syslog.py:0:0: E325 argument_spec for "validate_certs" defines type="bool" but documentation does not

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 24, 2018
@gundalow gundalow merged commit 7eda94d into ansible:devel Aug 28, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattclay mattclay mattclay left review comments

@lmprice lmprice lmprice approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 ci_verified Changes made in this PR are causing tests to fail. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. netapp new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. storage support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ndswartz @ansibot @mattclay @lmprice @gundalow @s-hertel @swartzn