Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_capabilities in nxapi module_utils should not return empty dictionary #42688

Merged
merged 1 commit into from Jul 13, 2018
Merged

get_capabilities in nxapi module_utils should not return empty dictionary #42688

merged 1 commit into from Jul 13, 2018

Conversation

trishnaguha
Copy link
Member

@trishnaguha trishnaguha commented Jul 12, 2018 •
edited

Signed-off-by: Trishna Guha trishnaguha17@gmail.com

SUMMARY

get_capabilities in nxapi module_utils should not return empty dictionary

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

module_utils/network/nxos/nxos.py

ANSIBLE VERSION
devel

@trishnaguha
Add get_capabilities in nxapi module_utils
5ad5934 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@ansibot
Copy link
Contributor

ansibot commented Jul 12, 2018

cc @Qalthos @ganeshrn @gdpak @gundalow @mikewiebe @privateip @rahushen @rcarrillocruz @tstoner
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Jul 12, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Jul 12, 2018
@trishnaguha trishnaguha changed the title get_capabilities in nxapi module_utils to support backward compatibility get_capabilities in nxapi module_utils should not return empty dictionary Jul 13, 2018
@trishnaguha trishnaguha removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jul 13, 2018
@trishnaguha trishnaguha merged commit d5e9653 into ansible:devel Jul 13, 2018
@trishnaguha trishnaguha deleted the get_capabilities_nxapi branch July 13, 2018 05:41
trishnaguha added a commit to trishnaguha/ansible that referenced this pull request Jul 13, 2018
@trishnaguha
Add get_capabilities in nxapi module_utils (ansible#42688)
dda18f8 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit d5e9653)
trishnaguha added a commit to trishnaguha/ansible that referenced this pull request Jul 13, 2018
@trishnaguha
Add get_capabilities in nxapi module_utils (ansible#42688)
e0e41b3 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit d5e9653)
@trishnaguha trishnaguha added this to Need CP into 2.6 in zzz NOT USED: Networking Bugs Jul 13, 2018
@trishnaguha trishnaguha self-assigned this Jul 13, 2018
mattclay pushed a commit that referenced this pull request Jul 17, 2018
@trishnaguha @mattclay
nxos bugfix cherry-pick 2.6 (#42724)
26f8b67 
* Add get_capabilities in nxapi module_utils (#42688)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit d5e9653)

* add changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
nitzmahone pushed a commit that referenced this pull request Jul 23, 2018
@trishnaguha @nitzmahone
nxos_nxapi fix pick-2.5 (#42490)
e3993bd 
* Enforcing NXAPI default HTTP behavior (#41817)

* nxos_nxapi http default behavior

* Use nxos_nxapi module in prepare_nxos_tests

* Refactor nxos_nxapi configure test to use yaml block

* Extend nxos_nxapi https & http test cases

* Removed NXOS internal release naming

* Resolved ansibot sanity errors

* Fix typo in prepare_nxos_tests

* Address PR comments

* Shippable indicates this is no longer needed

* Add port change logic and testing

(cherry picked from commit db73009)

* add changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add get_capabilities in nxapi module_utils (#42688)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit d5e9653)
@trishnaguha trishnaguha moved this from Need CP into 2.6 to Done in zzz NOT USED: Networking Bugs Jul 24, 2018
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@trishnaguha trishnaguha

Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cisco Cisco technologies module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
No open projects
zzz NOT USED: Networking Bugs
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@trishnaguha @ansibot @dagwieers @samdoran