Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ec2_group for numbered protocols (GRE) #42765

Merged
merged 6 commits into from
Sep 5, 2018
Merged

Fix ec2_group for numbered protocols (GRE) #42765

merged 6 commits into from
Sep 5, 2018

Commits on Jul 13, 2018

  1. Fix spurious changed=True when int is passed as tag

    @ryansb
    ryansb committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    71c41e3 View commit details
    Browse the repository at this point in the history

  2. Fix for all AWS module using compare_aws_tags

    @ryansb
    ryansb committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    4920e0d View commit details
    Browse the repository at this point in the history

  3. Handle improperly stringified protocols and allow inconsistency betwe… 

    …en None/-1 on non-tcp protocols
    @ryansb
    ryansb committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    eb6477a View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2018

  1. pep8

    @ryansb
    ryansb committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    8ddb1eb View commit details
    Browse the repository at this point in the history

  2. Add integration test that reproduces the same bug

    @ryansb
    ryansb committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    f069aed View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2018

  1. Return false if the comparsison is not equal 

    Add credentials to tests

pep8
    @s-hertel
    s-hertel committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    bab7f3f View commit details
    Browse the repository at this point in the history