Properly detect credentials for tower_project

[dmsimard]

SUMMARY

It seemed like it was mostly the wrong variables been looked at, making
it so a git repository could not be created without a credential, for example.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

tower_project

ANSIBLE VERSION

ansible 2.6.1
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /bin/ansible
  python version = 2.7.5 (default, Jul 13 2018, 13:06:57) [GCC 4.8.5 20150623 (Red Hat 4.8.5-28)]

ADDITIONAL INFORMATION

Before:

The full traceback is:
Traceback (most recent call last):
  File "/tmp/ansible_Ovkg7T/ansible_module_tower_project.py", line 174, in <module>
    main()
  File "/tmp/ansible_Ovkg7T/ansible_module_tower_project.py", line 151, in main
    cred = cred_res.get(name=scm_credential)
  File "/usr/lib/python2.7/site-packages/tower_cli/models/base.py", line 486, in get
    response = self.read(pk=pk, fail_on_no_results=True, fail_on_multiple_results=True, **kwargs)
  File "/usr/lib/python2.7/site-packages/tower_cli/models/base.py", line 306, in read
    raise exc.NotFound('The requested object could not be found.')
tower_cli.exceptions.NotFound: The requested object could not be found.

failed: [localhost] (item={u'name': u'bastion-tower', u'scm_clean': True, u'scm_url': u'https://github.com/dmsimard/bastion-tower', u'scm_type': u'git', u'organization': u'default-organization', u'description': u'Repository for infrastructure management'}) => {
    "changed": false, 
    "item": {
        "description": "Repository for infrastructure management", 
        "name": "bastion-tower", 
        "organization": "default-organization", 
        "scm_clean": true, 
        "scm_type": "git", 
        "scm_url": "https://github.com/dmsimard/bastion-tower"
    }, 
    "module_stderr": "Traceback (most recent call last):\n  File \"/tmp/ansible_Ovkg7T/ansible_module_tower_project.py\", line 174, in <module>\n    main()\n  File \"/tmp/ansible_Ovkg7T/ansible_module_tower_project.py\", line 151, in main\n    cred = cred_res.get(name=scm_credential)\n  File \"/usr/lib/python2.7/site-packages/tower_cli/models/base.py\", line 486, in get\n    response = self.read(pk=pk, fail_on_no_results=True, fail_on_multiple_results=True, **kwargs)\n  File \"/usr/lib/python2.7/site-packages/tower_cli/models/base.py\", line 306, in read\n    raise exc.NotFound('The requested object could not be found.')\ntower_cli.exceptions.NotFound: The requested object could not be found.\n", 
    "module_stdout": "", 
    "msg": "MODULE FAILURE", 
    "rc": 1
}

After:

TASK [tower-config : Configure Tower projects] ********************************
Tuesday 24 July 2018  15:18:34 +0000 (0:00:00.846)       0:00:03.225 ********** 
changed: [localhost] => (item={u'name': u'bastion-tower', u'scm_clean': True, u'scm_url': u'https://github.com/dmsimard/bastion-tower', u'scm_type': u'git', u'organization': u'default-organization', u'description': u'Repository for infrastructure management'})

[ansibot]

cc @AlanCoding @ghjm @jlaska @matburt @rooftopcellist @ryanpetrello @simfarm @wwitzel3
click here for bot help

[AlanCoding]

I'd rather not have a variable scm_credential and credential. You could just call this scm_credential, and supply that in the project.modify call.

[dmsimard]

Sure.

[AlanCoding]

this looks great 👍

[pilou-]

Isn't None the default value already ?

[dmsimard]

Hmm, good point, I somehow felt the need to make it explicity. Let me fix that.

[AlanCoding]

shipit

[pilou-]

LGTM : test is executed and run without any error.

[ryanpetrello]

shipit

[dmsimard]

@AlanCoding I think your shipit doesn't count because I did a slight modification afterwards :/

[AlanCoding]

shipit