ACI: Rewrite construct_url framework #43441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.7
This comment has been minimized.
This comment has been minimized.
ansibot
added
ci_verified
dagwieers
force-pushed
the
aci_iplpg_lagt
branch
from
aef6ad2
to
188b66f
Compare
ansibot
added
community_review
dagwieers
force-pushed
the
aci_iplpg_lagt
branch
from
188b66f
to
b91c704
Compare
ansibot
removed
needs_ci
dagwieers
force-pushed
the
aci_iplpg_lagt
branch
from
b91c704
to
6d0739f
Compare
ansibot
added
test
dagwieers
force-pushed
the
aci_iplpg_lagt
branch
2 times, most recently
from
8d425eb
to
98c660d
Compare
ansibot
removed
the
ci_verified
dagwieers
force-pushed
the
aci_iplpg_lagt
branch
2 times, most recently
from
a543cb6
to
5dbdc3b
Compare
dagwieers
force-pushed
the
aci_iplpg_lagt
branch
7 times, most recently
from
b786a69
to
6f9f238
Compare
dagwieers
removed
needs_rebase
ansibot
added
needs_rebase
|
@jmcgill298 @brunocalogero @schunduri @rsmeyers @smnmtzgr @nilloBE I think this is ready to be merged, but would appreciate more testing. |
|
bot_skip |
dagwieers
removed
needs_rebase
This functionality was not considered when the module was written, but there's no reason why it shouldn't be supported. We had to rework the query string construction and object filtering. This new functionality allows to filter on arbitrary keys and supports None values. This PR fixes various issues with the existing framework, including querying specific objects using construct_url_4 (i.e. aci_epg_to_contract and aci_static_binding_to_epg)
dagwieers
force-pushed
the
aci_iplpg_lagt
branch
from
6f9f238
to
52559d8
Compare
|
In all my tests the rewrite worked or fixed known issues. So I am going to merge it now. |
dagwieers
changed the title
This was referenced Sep 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This functionality was not considered when the module was written, but
there's no reason why it shouldn't be supported.
We had to rework the query string construction and object filtering.
This new functionality allows to filter on arbitrary keys and supports
None values.
This PR also fixes various issues with the existing framework, including
querying specific objects using construct_url_4 (i.e.
aci_epg_to_contract and aci_static_binding_to_epg)
This fixes #43422
ISSUE TYPE
COMPONENT NAME
aci_interface_policy_leaf_policy_group
ANSIBLE VERSION
v2.7