Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ElementSW Snapshot Restore Module #43973

Merged
merged 4 commits into from Aug 28, 2018
Merged

Adding ElementSW Snapshot Restore Module #43973

merged 4 commits into from Aug 28, 2018

Conversation

carchi8py
Copy link
Contributor

SUMMARY

Adding ElementSW Snapshot Restore Module

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
  • na_elementsw_snapshot_restore.py
ANSIBLE VERSION
bash-3.2# ansible --version
ansible 2.7.0.dev0 (sf_commonfiles caf71e24dd) last updated 2018/08/06 10:46:57 (GMT -700)
  config file = None
  configured module search path = [u'/Users/chrisarchibald/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /private/tmp/ansible/lib/ansible
  executable location = /private/tmp/ansible/bin/ansible
  python version = 2.7.12 (default, Oct 11 2016, 05:20:59) [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.38)]
ADDITIONAL INFORMATION

schmots1
schmots1 approved these changes Aug 10, 2018
View reviewed changes
Copy link
Contributor

@schmots1 schmots1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot
Copy link
Contributor

ansibot commented Aug 10, 2018

cc @amit0701 @hulquest @lmprice @ndswartz @schmots1
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 module This issue/PR relates to a module. netapp new_module This PR includes a new module. new_plugin This PR includes a new plugin. shipit This PR is ready to be merged by Core storage support:community This issue/PR relates to code supported by the Ansible community. labels Aug 10, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 10, 2018

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/na_elementsw_snapshot_restore.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/na_elementsw_snapshot_restore.py:2:1: SyntaxError:

The test ansible-test sanity --test line-endings [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/na_elementsw_snapshot_restore.py:0:0: use "\n" for line endings instead of "\r\n"

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed shipit This PR is ready to be merged by Core labels Aug 10, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Aug 10, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 10, 2018

@amit0701 @hulquest @lmprice @ndswartz @schmots1

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 10, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 18, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 23, 2018
schmots1
schmots1 approved these changes Aug 23, 2018
View reviewed changes
Copy link
Contributor

@schmots1 schmots1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 23, 2018
gundalow
gundalow requested changes Aug 28, 2018
View reviewed changes
lib/ansible/modules/storage/netapp/na_elementsw_snapshot_restore.py Outdated
- Account ID or Name of Parent/Source Volume.
required: true

password:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are username and password define here, though should be in the docs_fragment.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed shipit This PR is ready to be merged by Core labels Aug 28, 2018
@gundalow gundalow merged commit 0f31111 into ansible:devel Aug 28, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

@schmots1 schmots1 schmots1 approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. netapp new_module This PR includes a new module. new_plugin This PR includes a new plugin. storage support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@carchi8py @ansibot @gundalow @schmots1