The first module of Telefonica cloud #44256

zengchen1024 · 2018-08-16T08:56:49Z

SUMMARY
This pr wants to add the first module of Telefonica cloud.

ISSUE TYPE
Feature Pull Request

ansibot · 2018-08-16T09:38:10Z

The test ansible-test sanity --test no-underscore-variable [explain] failed with 2 errors:

lib/ansible/modules/cloud/telefonica/tfc_app_smn_topic.py:60:53: use `dummy` instead of `_` for a variable name
lib/ansible/modules/cloud/telefonica/tfc_app_smn_topic.py:96:53: use `dummy` instead of `_` for a variable name

click here for bot help

mattclay · 2018-08-28T04:07:31Z

test/integration/cloud-config-hwc.yml.template

@@ -0,0 +1,10 @@
+# This is the configuration template for ansible-test HWC integration tests.


This file is not needed since there is no cloud test plugin using it.

thanks, I will remove it!

ansibot · 2018-10-27T10:32:06Z

@zengchen1024 this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

ansibot · 2018-10-27T11:30:41Z

The test ansible-test sanity --test pylint [explain] failed with 4 errors:

test/units/module_utils/hwc/test_dict_comparison.py:34:24: comparison-with-itself Redundant comparison - d == d
test/units/module_utils/hwc/test_dict_comparison.py:66:24: comparison-with-itself Redundant comparison - d == d
test/units/module_utils/hwc/test_dict_comparison.py:111:24: comparison-with-itself Redundant comparison - d == d
test/units/module_utils/hwc/test_dict_comparison.py:153:24: comparison-with-itself Redundant comparison - d == d

The test ansible-test sanity --test pylint [explain] failed with 18 errors:

lib/ansible/modules/cloud/telefonica/tfc_manage_ces_alarm_rule.py:32:0: anomalous-backslash-in-string Anomalous backslash in string: '\-'. String constant might be missing an r prefix.
lib/ansible/modules/cloud/telefonica/tfc_manage_ces_alarm_rule.py:32:0: anomalous-backslash-in-string Anomalous backslash in string: '\-'. String constant might be missing an r prefix.
lib/ansible/modules/cloud/telefonica/tfc_manage_ces_alarm_rule.py:32:0: anomalous-backslash-in-string Anomalous backslash in string: '\-'. String constant might be missing an r prefix.
lib/ansible/modules/cloud/telefonica/tfc_manage_ces_alarm_rule.py:32:0: anomalous-backslash-in-string Anomalous backslash in string: '\-'. String constant might be missing an r prefix.
lib/ansible/modules/cloud/telefonica/tfc_manage_ces_alarm_rule.py:32:0: anomalous-backslash-in-string Anomalous backslash in string: '\-'. String constant might be missing an r prefix.
lib/ansible/modules/cloud/telefonica/tfc_manage_ces_alarm_rule.py:32:0: anomalous-backslash-in-string Anomalous backslash in string: '\-'. String constant might be missing an r prefix.
lib/ansible/modules/cloud/telefonica/tfc_manage_ces_alarm_rule.py:32:0: anomalous-backslash-in-string Anomalous backslash in string: '\_'. String constant might be missing an r prefix.
lib/ansible/modules/cloud/telefonica/tfc_manage_ces_alarm_rule.py:32:0: anomalous-backslash-in-string Anomalous backslash in string: '\_'. String constant might be missing an r prefix.
lib/ansible/modules/cloud/telefonica/tfc_manage_ces_alarm_rule.py:32:0: anomalous-backslash-in-string Anomalous backslash in string: '\_'. String constant might be missing an r prefix.
lib/ansible/modules/cloud/telefonica/tfc_manage_ces_alarm_rule.py:286:0: anomalous-backslash-in-string Anomalous backslash in string: '\-'. String constant might be missing an r prefix.
lib/ansible/modules/cloud/telefonica/tfc_manage_ces_alarm_rule.py:286:0: anomalous-backslash-in-string Anomalous backslash in string: '\-'. String constant might be missing an r prefix.
lib/ansible/modules/cloud/telefonica/tfc_manage_ces_alarm_rule.py:286:0: anomalous-backslash-in-string Anomalous backslash in string: '\-'. String constant might be missing an r prefix.
lib/ansible/modules/cloud/telefonica/tfc_manage_ces_alarm_rule.py:286:0: anomalous-backslash-in-string Anomalous backslash in string: '\-'. String constant might be missing an r prefix.
lib/ansible/modules/cloud/telefonica/tfc_manage_ces_alarm_rule.py:286:0: anomalous-backslash-in-string Anomalous backslash in string: '\-'. String constant might be missing an r prefix.
lib/ansible/modules/cloud/telefonica/tfc_manage_ces_alarm_rule.py:286:0: anomalous-backslash-in-string Anomalous backslash in string: '\-'. String constant might be missing an r prefix.
lib/ansible/modules/cloud/telefonica/tfc_manage_ces_alarm_rule.py:286:0: anomalous-backslash-in-string Anomalous backslash in string: '\_'. String constant might be missing an r prefix.
lib/ansible/modules/cloud/telefonica/tfc_manage_ces_alarm_rule.py:286:0: anomalous-backslash-in-string Anomalous backslash in string: '\_'. String constant might be missing an r prefix.
lib/ansible/modules/cloud/telefonica/tfc_manage_ces_alarm_rule.py:286:0: anomalous-backslash-in-string Anomalous backslash in string: '\_'. String constant might be missing an r prefix.

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 4 errors:

lib/ansible/modules/cloud/telefonica/tfc_compute_as_config.py:0:0: has a documentation error formatting or is missing documentation.
lib/ansible/modules/cloud/telefonica/tfc_compute_as_group.py:0:0: has a documentation error formatting or is missing documentation.
lib/ansible/modules/cloud/telefonica/tfc_compute_as_policy.py:0:0: has a documentation error formatting or is missing documentation.
lib/ansible/modules/cloud/telefonica/tfc_manage_ces_alarm_rule.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 4 errors:

lib/ansible/modules/cloud/telefonica/tfc_compute_as_config.py:0:0: has a documentation error formatting or is missing documentation.
lib/ansible/modules/cloud/telefonica/tfc_compute_as_group.py:0:0: has a documentation error formatting or is missing documentation.
lib/ansible/modules/cloud/telefonica/tfc_compute_as_policy.py:0:0: has a documentation error formatting or is missing documentation.
lib/ansible/modules/cloud/telefonica/tfc_manage_ces_alarm_rule.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 4 errors:

lib/ansible/modules/cloud/telefonica/tfc_compute_as_config.py:0:0: has a documentation error formatting or is missing documentation.
lib/ansible/modules/cloud/telefonica/tfc_compute_as_group.py:0:0: has a documentation error formatting or is missing documentation.
lib/ansible/modules/cloud/telefonica/tfc_compute_as_policy.py:0:0: has a documentation error formatting or is missing documentation.
lib/ansible/modules/cloud/telefonica/tfc_manage_ces_alarm_rule.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 4 errors:

lib/ansible/modules/cloud/telefonica/tfc_compute_as_config.py:0:0: has a documentation error formatting or is missing documentation.
lib/ansible/modules/cloud/telefonica/tfc_compute_as_group.py:0:0: has a documentation error formatting or is missing documentation.
lib/ansible/modules/cloud/telefonica/tfc_compute_as_policy.py:0:0: has a documentation error formatting or is missing documentation.
lib/ansible/modules/cloud/telefonica/tfc_manage_ces_alarm_rule.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 4 errors:

lib/ansible/modules/cloud/telefonica/tfc_compute_as_config.py:0:0: has a documentation error formatting or is missing documentation.
lib/ansible/modules/cloud/telefonica/tfc_compute_as_group.py:0:0: has a documentation error formatting or is missing documentation.
lib/ansible/modules/cloud/telefonica/tfc_compute_as_policy.py:0:0: has a documentation error formatting or is missing documentation.
lib/ansible/modules/cloud/telefonica/tfc_manage_ces_alarm_rule.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
cat _themes/srtd/static/css/theme.css | sed -e 's/^[ 	]*//g; s/[ 	]*$//g; s/\([:{;,]\) /\1/g; s/ {/{/g; s/\/\*.*\*\///g; /^$/d' | sed -e :a -e '$!N; s/\n\(.\)/\1/; ta' > _themes/srtd/static/css/theme.min.css
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 720, in <module>
    main()
  File "../bin/plugin_formatter.py", line 678, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 269, in get_plugin_info
    doc, examples, returndocs, metadata = plugin_docs.get_docstring(module_path, fragment_loader, verbose=verbose)
  File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 99, in get_docstring
    data = read_docstring(filename, verbose=verbose, ignore_errors=ignore_errors)
  File "/root/ansible/lib/ansible/parsing/plugin_docs.py", line 62, in read_docstring
    data[varkey] = AnsibleLoader(child.value.s, file_name=filename).get_single_data()
  File "/usr/local/lib/python3.6/dist-packages/yaml/constructor.py", line 35, in get_single_data
    node = self.get_single_node()
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 36, in get_single_node
    document = self.compose_document()
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 55, in compose_document
    node = self.compose_node(None, None)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 82, in compose_node
    node = self.compose_sequence_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 111, in compose_sequence_node
    node.value.append(self.compose_node(node, index))
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 127, in compose_mapping_node
    while not self.check_event(MappingEndEvent):
  File "/usr/local/lib/python3.6/dist-packages/yaml/parser.py", line 98, in check_event
    self.current_event = self.state()
  File "/usr/local/lib/python3.6/dist-packages/yaml/parser.py", line 428, in parse_block_mapping_key
    if self.check_token(KeyToken):
  File "/usr/local/lib/python3.6/dist-packages/yaml/scanner.py", line 115, in check_token
    while self.need_more_tokens():
  File "/usr/local/lib/python3.6/dist-packages/yaml/scanner.py", line 149, in need_more_tokens
    self.stale_possible_simple_keys()
  File "/usr/local/lib/python3.6/dist-packages/yaml/scanner.py", line 289, in stale_possible_simple_keys
    "could not find expected ':'", self.get_mark())
yaml.scanner.ScannerError: while scanning a simple key
  in "<unicode string>", line 39, column 31:
                                  configuration or not. If DSS dev ... 
                                  ^
could not find expected ':'
  in "<unicode string>", line 40, column 31:
                                  specified, all the data stores m ... 
                                  ^
make: *** [modules] Error 1

click here for bot help

ansibot · 2018-10-29T08:57:02Z

The test ansible-test sanity --test pylint [explain] failed with 4 errors:

test/units/module_utils/hwc/test_dict_comparison.py:34:24: comparison-with-itself Redundant comparison - d == d
test/units/module_utils/hwc/test_dict_comparison.py:66:24: comparison-with-itself Redundant comparison - d == d
test/units/module_utils/hwc/test_dict_comparison.py:111:24: comparison-with-itself Redundant comparison - d == d
test/units/module_utils/hwc/test_dict_comparison.py:153:24: comparison-with-itself Redundant comparison - d == d

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/telefonica/tfc_app_smn_topic.py:325:1: E303 too many blank lines (4)

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/telefonica/tfc_app_smn_topic.py:0:0: E307 version_added should be 2.8. Currently 2.7

click here for bot help

mattclay · 2018-10-29T15:48:21Z

test/units/module_utils/hwc/test_dict_comparison.py

+            'test': 'original'
+        }
+        d = DictComparison(value1)
+        self.assertTrue(d == d)


Use self.assertEqual(d, d) instead of self.assertTrue(d == d).

@mattclay Thanks for your reviewing! I have done the modification. Please review again. Thanks!

zengchen1024 · 2018-11-05T08:28:12Z

@mattclay Could you please take a look at this pr? Thank you very much!!!

Click2Cloud-Gamma · 2018-12-05T05:54:41Z

@mattclay It would be really great if you can share your feedback regarding the PR OR please review it once again?

Click2Cloud-Gamma · 2018-12-10T05:01:56Z

bot_status

Click2Cloud-Gamma · 2018-12-13T05:46:16Z

@ansibot @mattclay @samdoran The PR is ready_for_review. Could you please review it.

Click2Cloud-Gamma · 2018-12-18T04:32:04Z

@ansibot @mattclay @samdoran Please have a look at this PR and review it once again. Thank you so much.
ready_for_review

Click2Cloud-Gamma · 2018-12-25T10:42:46Z

@ansibot @mattclay Could you please review this PR once again for further process. Thank you so much.
ready_for_review

Click2Cloud-Gamma · 2019-01-07T04:17:22Z

@ansibot @mattclay @samdoran The PR is ready_for_review. Could you please review it.

zengchen1024 · 2019-01-16T13:54:40Z

@ansibot @mattclay @samdoran The PR is ready_for_review. Could you please review it.

Click2Cloud-Gamma · 2019-02-13T09:20:26Z

@ansibot @mattclay @samdoran Please have a look at this PR and review it once again.
ready_for_review

ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 16, 2018

samdoran removed the needs_triage Needs a first human triage before being processed. label Aug 16, 2018

zengchen1024 force-pushed the new_smn_topic branch 2 times, most recently from 037dfad to 859befe Compare August 20, 2018 06:44

mattclay reviewed Aug 28, 2018

View reviewed changes

ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 28, 2018

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 5, 2018

zengchen1024 force-pushed the new_smn_topic branch from 25cf1c6 to 7fdf21d Compare October 27, 2018 10:26

zengchen1024 force-pushed the new_smn_topic branch 2 times, most recently from 2045cb4 to c8a6525 Compare October 29, 2018 08:15

ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Oct 29, 2018

mattclay reviewed Oct 29, 2018

View reviewed changes

zengchen1024 added 2 commits October 30, 2018 14:31

add module of smn topic

2dccbec

fix some format errors

8128340

zengchen1024 force-pushed the new_smn_topic branch from a044b48 to 8128340 Compare October 30, 2018 06:31

ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 30, 2018

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 13, 2018

zengchen1024 closed this Dec 12, 2018

zengchen1024 reopened this Dec 12, 2018

ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 12, 2018

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 25, 2018

zengchen1024 closed this Mar 29, 2019

ansible locked and limited conversation to collaborators Jul 25, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

The first module of Telefonica cloud #44256

The first module of Telefonica cloud #44256

zengchen1024 commented Aug 16, 2018

ansibot commented Aug 16, 2018

mattclay Aug 28, 2018

zengchen1024 Aug 28, 2018

ansibot commented Oct 27, 2018

ansibot commented Oct 27, 2018

ansibot commented Oct 29, 2018

mattclay Oct 29, 2018

zengchen1024 Oct 30, 2018

zengchen1024 commented Nov 5, 2018

Click2Cloud-Gamma commented Dec 5, 2018

Click2Cloud-Gamma commented Dec 10, 2018

Click2Cloud-Gamma commented Dec 13, 2018

Click2Cloud-Gamma commented Dec 18, 2018

Click2Cloud-Gamma commented Dec 25, 2018

Click2Cloud-Gamma commented Jan 7, 2019

zengchen1024 commented Jan 16, 2019

Click2Cloud-Gamma commented Feb 13, 2019

		@@ -0,0 +1,10 @@
		# This is the configuration template for ansible-test HWC integration tests.

The first module of Telefonica cloud #44256

The first module of Telefonica cloud #44256

Conversation

zengchen1024 commented Aug 16, 2018

ansibot commented Aug 16, 2018

mattclay Aug 28, 2018

Choose a reason for hiding this comment

zengchen1024 Aug 28, 2018

Choose a reason for hiding this comment

ansibot commented Oct 27, 2018

ansibot commented Oct 27, 2018

ansibot commented Oct 29, 2018

mattclay Oct 29, 2018

Choose a reason for hiding this comment

zengchen1024 Oct 30, 2018

Choose a reason for hiding this comment

zengchen1024 commented Nov 5, 2018

Click2Cloud-Gamma commented Dec 5, 2018

Click2Cloud-Gamma commented Dec 10, 2018

Click2Cloud-Gamma commented Dec 13, 2018

Click2Cloud-Gamma commented Dec 18, 2018

Click2Cloud-Gamma commented Dec 25, 2018

Click2Cloud-Gamma commented Jan 7, 2019

zengchen1024 commented Jan 16, 2019

Click2Cloud-Gamma commented Feb 13, 2019