Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise a nicer error when we cannot execute the editor #44423

Merged
merged 3 commits into from
Aug 22, 2018
Merged

Raise a nicer error when we cannot execute the editor #44423

merged 3 commits into from
Aug 22, 2018

Conversation

sivel
Copy link
Member

@sivel sivel commented Aug 20, 2018

SUMMARY

Raise a nicer error when we cannot execute the editor. Fixes #44419

Additionally, while fixing this, I encountered the following error, and addressed the use of to_bytes in building exceptions

ERROR! b'Decryption failed (no vault secrets were found that could decrypt)' for b'/Users/matt/projects/ansibledev/playbooks/vault.yml'
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/parsing/vault

ANSIBLE VERSION
2.5
2.6
2.7
ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 20, 2018
@sivel sivel requested a review from abadger August 20, 2018 22:03
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Aug 22, 2018
@sivel sivel merged commit 81ca045 into ansible:devel Aug 22, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abadger abadger Awaiting requested review from abadger

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ansible-vault traceback when configured EDITOR doesn't exist
2 participants
@sivel @ansibot