Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcd3 lookup: new lookup #44626

Closed
wants to merge 1 commit into from
Closed

etcd3 lookup: new lookup #44626

wants to merge 1 commit into from

Conversation

vfauth
Copy link
Contributor

@vfauth vfauth commented Aug 24, 2018

SUMMARY

Add a new lookup plugin to get data from a etcd3 server.
Similar to #42759 but with a refactored code which supports authentication and TLS secure connections.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lookup etcd3

ANSIBLE VERSION
ansible 2.5.1
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/victor/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/dist-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.15rc1 (default, Apr 15 2018, 21:51:34) [GCC 7.3.0]

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. new_plugin This PR includes a new plugin. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 24, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 24, 2018

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/plugins/lookup/etcd3.py:88:1: E302 expected 2 blank lines, found 1
lib/ansible/plugins/lookup/etcd3.py:111:114: E202 whitespace before ']'

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/plugins/lookup/etcd3.py:62:54: error EXAMPLES: syntax error: expected <block end>, but found '<scalar>'

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 24, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Aug 24, 2018
@vfauth vfauth mentioned this pull request Aug 24, 2018
Closed
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Aug 24, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Aug 24, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 1, 2018
@ansibot ansibot added support:community This issue/PR relates to code supported by the Ansible community. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 17, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. community_review In order to be merged, this PR must follow the community review workflow. labels Oct 23, 2018
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 31, 2018
@maxamillion
Copy link
Contributor

Hello and thank you for your pull request!

Any chance we can get some integration tests for this? It would be nice to verify that it functions and that we don't cause regressions over time. Thanks again!

@ansibot ansibot removed the new_contributor This PR is the first contribution by a new community member. label Feb 17, 2019
@chris93111
Copy link
Contributor

+1 work for me thanks

@chris93111
Copy link
Contributor

chris93111 commented Apr 6, 2019 •
edited

@vfauth @maxamillion I can help if needed integration test

This was referenced Apr 7, 2019
Closed
Closed
@chris93111
Copy link
Contributor

posted in #54961

@chris93111 chris93111 mentioned this pull request Apr 11, 2019
Closed
@Akasurde
Copy link
Member

Akasurde commented Jul 2, 2020

@vfauth Thanks for the contribution. etcd3 lookup plugin is merged via ansible-collections/community.general#127.

@Akasurde Akasurde closed this Jul 2, 2020
@ansible ansible locked and limited conversation to collaborators Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. new_plugin This PR includes a new plugin. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vfauth @ansibot @maxamillion @chris93111 @Akasurde @samdoran