Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os_server_facts: support all_projects #44800

Merged
merged 2 commits into from Nov 8, 2018
Merged

os_server_facts: support all_projects #44800

merged 2 commits into from Nov 8, 2018

Conversation

jamescassell
Copy link
Contributor

SUMMARY

Fixes #39542

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

os_server_facts

ANSIBLE VERSION
ansible 2.7.0.a1.post0 (os-server-facts-all-projects fd913bd183) last updated 2018/08/28 21:10:33 (GMT -400)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/user/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/user/ansible-ansible/lib/ansible
  executable location = /home/user/ansible-ansible/bin/ansible
  python version = 2.7.5 (default, Jul 13 2018, 13:06:57) [GCC 4.8.5 20150623 (Red Hat 4.8.5-28)]
ADDITIONAL INFORMATION

Mostly just used the diff from the related bug.

@ansibot
Copy link
Contributor

ansibot commented Aug 29, 2018

cc @dagnello @emonty @juliakreger @omgjlk @rcarrillocruz @Shrews @Thingee
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. openstack support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 29, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 29, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server_facts.py:0:0: E309 version_added for new option (all_projects) should be 2.7. Currently 0.0

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 29, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 29, 2018
@jamescassell
Copy link
Contributor Author

Out of curiosity, what triggers the core_review vs community_review?

@opendev-zuul
Copy link

opendev-zuul bot commented Aug 29, 2018

Build succeeded (third-party-check pipeline).

@opendev-zuul
Copy link

opendev-zuul bot commented Aug 29, 2018

Build succeeded (third-party-check pipeline).

@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Aug 30, 2018
@jamescassell
Copy link
Contributor Author

Any chance this could make it for 2.7?

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 12, 2018
@jamescassell jamescassell reopened this Sep 12, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 12, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 12, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server_facts.py:0:0: E309 version_added for new option (all_projects) should be 2.8. Currently 2.7

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Sep 12, 2018
@opendev-zuul
Copy link

opendev-zuul bot commented Oct 8, 2018

Build succeeded (third-party-check pipeline).

@ansibot
Copy link
Contributor

ansibot commented Oct 10, 2018

@jamescassell: thank you for submitting this pull-request!

cc @mnaser
click here for bot help

@mnaser
Copy link
Contributor

mnaser commented Oct 13, 2018

shipit

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 16, 2018
@jamescassell jamescassell reopened this Oct 23, 2018
@jamescassell jamescassell mentioned this pull request Oct 23, 2018
Closed
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 23, 2018
@opendev-zuul
Copy link

opendev-zuul bot commented Oct 23, 2018

Build succeeded (third-party-check pipeline).

@samdoran samdoran self-assigned this Oct 25, 2018
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Oct 25, 2018
@opendev-zuul
Copy link

opendev-zuul bot commented Oct 25, 2018

Build succeeded (third-party-check pipeline).

@jamescassell
Copy link
Contributor Author

@mnaser @odyssey4me any chance one of you could take a quick look if/when you get a chance?

@ansibot
Copy link
Contributor

ansibot commented Nov 1, 2018

cc @cloudnull @evrardjp
click here for bot help

@opendev-zuul
Copy link

opendev-zuul bot commented Nov 1, 2018

Build succeeded (third-party-check pipeline).

@odyssey4me
Copy link
Contributor

shipit

@jamescassell
Copy link
Contributor Author

bot_status

@ansibot
Copy link
Contributor

ansibot commented Nov 5, 2018

Components

changelogs/fragments/os-server-facts-all-projects.yaml
support: community
maintainers:

lib/ansible/modules/cloud/openstack/os_server_facts.py
support: community
maintainers: cloudnull dagnello emonty evrardjp juliakreger mnaser odyssey4me rcarrillocruz shrews

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 1
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): odyssey4me
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@samdoran samdoran merged commit c13fa50 into ansible:devel Nov 8, 2018
Ghilli3 pushed a commit to Ghilli3/ansible that referenced this pull request Nov 12, 2018
@jamescassell @Ghilli3
os_server_facts: support all_projects (ansible#44800)
bc7f513 
* os_server_facts: support all_projects

* os_server_facts: openstacksdk expects True or False, not None
mjmayer pushed a commit to mjmayer/ansible that referenced this pull request Nov 30, 2018
@jamescassell @mjmayer
os_server_facts: support all_projects (ansible#44800)
63cc034 
* os_server_facts: support all_projects

* os_server_facts: openstacksdk expects True or False, not None
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@jamescassell @Tomorrow9
os_server_facts: support all_projects (ansible#44800)
1b5bdbb 
* os_server_facts: support all_projects

* os_server_facts: openstacksdk expects True or False, not None
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abadger abadger abadger left review comments

@bcoca bcoca bcoca left review comments

@samdoran samdoran samdoran left review comments

Assignees

@samdoran samdoran

Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. openstack support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

os_server_facts does not provide --all-projects function for admin users
8 participants
@jamescassell @ansibot @mnaser @odyssey4me @abadger @bcoca @samdoran @jborean93