Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce and use locale-naive rfc2822 date format function #44868

Merged
merged 2 commits into from Aug 30, 2018
Merged

Introduce and use locale-naive rfc2822 date format function #44868

merged 2 commits into from Aug 30, 2018

Conversation

sivel
Copy link
Member

@sivel sivel commented Aug 29, 2018

SUMMARY

Introduce and use locale-naive rfc2822 date format function. Fixes #44857

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/module_utils/urls.py
lib/ansible/modules/net_tools/basics/uri.py

ANSIBLE VERSION
2.7
2.6
2.5
ADDITIONAL INFORMATION

@sivel sivel requested a review from abadger August 29, 2018 21:11
@sivel sivel mentioned this pull request Aug 29, 2018
Closed
@abadger
Copy link
Contributor

abadger commented Aug 29, 2018

Looks good. +1 from me.

@ansibot
Copy link
Contributor

ansibot commented Aug 29, 2018

cc @romeotheriault
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. net_tools Net-tools category support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 29, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 29, 2018
@sivel sivel merged commit 0221d1a into ansible:devel Aug 30, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@achinthagunasekara achinthagunasekara achinthagunasekara approved these changes

@abadger abadger Awaiting requested review from abadger

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. net_tools Net-tools category support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get_url gives confusing error message when destination already exists
4 participants
@sivel @abadger @ansibot @achinthagunasekara