Ovirt add rename functionality #44951

mnecas · 2018-08-31T08:32:29Z

SUMMARY

Now you can rename most of ovirt components. When you pass components ID then you can change name.

Fixes #43236

ISSUE TYPE

Feature Pull Request
Bugfix Pull Request

COMPONENT NAME

ovirt

ANSIBLE VERSION

ansible 2.6.3
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/mnecas/Desktop/Projects/Redhat/ansible/lib/ansible/modules/cloud/ovirt']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.15 (default, May 16 2018, 17:50:09) [GCC 8.1.1 20180502 (Red Hat 8.1.1-1)]

ADDITIONAL INFORMATION

ansibot · 2018-08-31T08:38:40Z

cc @machacekondra @mwperina
click here for bot help

ansibot · 2018-08-31T08:46:53Z

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/ovirt/ovirt_mac_pool.py:133:0: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/cloud/ovirt/ovirt_mac_pool.py:133:78: W291 trailing whitespace
lib/ansible/modules/cloud/ovirt/ovirt_nic.py:106:13: W291 trailing whitespace

click here for bot help

mwperina

shipit

machacekondra · 2018-08-31T11:09:31Z

lib/ansible/modules/cloud/ovirt/ovirt_cluster.py

+# Change cluster Name
+- ovirt_cluster:
+    id: 00000000-0000-0000-0000-000000000000
+    name: "new cluster name"


There can't be spaces in cluster name.

machacekondra · 2018-08-31T11:10:07Z

lib/ansible/modules/cloud/ovirt/ovirt_datacenter.py

+# Change Datacenter Name
+- ovirt_datacenter:
+    id: 00000000-0000-0000-0000-000000000000
+    name: "new datacenter name"


Here as well.

machacekondra · 2018-08-31T11:16:03Z

lib/ansible/modules/cloud/ovirt/ovirt_host.py

@@ -18,6 +18,10 @@
 description:
    - "Module to manage hosts in oVirt/RHV"
 options:
+    id:
+        description:
+            - "ID of the nic to manage."


machacekondra · 2018-08-31T11:10:53Z

lib/ansible/modules/cloud/ovirt/ovirt_mac_pool.py

+# Change MAC pool Name
+- ovirt_nic:
+    id: 00000000-0000-0000-0000-000000000000
+    name: "new mac pool name"


machacekondra · 2018-08-31T11:11:29Z

lib/ansible/modules/cloud/ovirt/ovirt_network.py

+# Change Network Name
+- ovirt_network:
+    id: 00000000-0000-0000-0000-000000000000
+    name: "new network name"


machacekondra · 2018-08-31T11:13:28Z

lib/ansible/modules/cloud/ovirt/ovirt_tag.py

+# Change cluster Name
+- ovirt_tag:
+    id: 00000000-0000-0000-0000-000000000000
+    name: "new tag name"


No spaces. s/new tag name/new_cluster_name

machacekondra · 2018-08-31T11:13:32Z

lib/ansible/modules/cloud/ovirt/ovirt_template.py

+# Change Template Name
+- ovirt_template:
+    id: 00000000-0000-0000-0000-000000000000
+    name: "new template name"


machacekondra · 2018-08-31T11:13:40Z

lib/ansible/modules/cloud/ovirt/ovirt_vm.py

+# Change VM Name
+- ovirt_vmpool:
+    id: 00000000-0000-0000-0000-000000000000
+    name: "new vm name"


machacekondra · 2018-08-31T11:14:20Z

lib/ansible/modules/cloud/ovirt/ovirt_vm.py

@@ -677,6 +677,11 @@
    nics:
      - name: nic1

+# Change VM Name
+- ovirt_vmpool:


machacekondra · 2018-08-31T11:14:51Z

lib/ansible/modules/cloud/ovirt/ovirt_vmpool.py

+# Change Pool Name
+- ovirt_vmpool:
+    id: 00000000-0000-0000-0000-000000000000
+    name: "new disk name"


No spaces. s/new disk name/new_pool_name

machacekondra · 2018-08-31T11:16:03Z

lib/ansible/modules/cloud/ovirt/ovirt_host.py

@@ -18,6 +18,10 @@
 description:
    - "Module to manage hosts in oVirt/RHV"
 options:
+    id:
+        description:
+            - "ID of the nic to manage."


machacekondra · 2018-08-31T11:57:11Z

shipit

mwperina

shipit

mwperina · 2018-08-31T13:58:33Z

Ondro, maybe you will need to approve the PR to get this merged automatically?
@machacekondra

mwperina · 2018-08-31T13:58:47Z

bot_status

ansibot · 2018-09-03T06:44:47Z

Components

lib/ansible/modules/cloud/ovirt/ovirt_cluster.py
support: community
maintainers: machacekondra mwperina

lib/ansible/modules/cloud/ovirt/ovirt_datacenter.py
support: community
maintainers: machacekondra mwperina

lib/ansible/modules/cloud/ovirt/ovirt_disk.py
support: community
maintainers: machacekondra mwperina

lib/ansible/modules/cloud/ovirt/ovirt_host.py
support: community
maintainers: machacekondra mwperina

lib/ansible/modules/cloud/ovirt/ovirt_mac_pool.py
support: community
maintainers: machacekondra mwperina

lib/ansible/modules/cloud/ovirt/ovirt_network.py
support: community
maintainers: machacekondra mwperina

lib/ansible/modules/cloud/ovirt/ovirt_nic.py
support: community
maintainers: machacekondra mwperina

lib/ansible/modules/cloud/ovirt/ovirt_quota.py
support: community
maintainers: machacekondra mwperina

lib/ansible/modules/cloud/ovirt/ovirt_tag.py
support: community
maintainers: machacekondra mwperina

lib/ansible/modules/cloud/ovirt/ovirt_template.py
support: community
maintainers: machacekondra mwperina

lib/ansible/modules/cloud/ovirt/ovirt_vm.py
support: community
maintainers: machacekondra mwperina

lib/ansible/modules/cloud/ovirt/ovirt_vmpool.py
support: community
maintainers: machacekondra mwperina

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 2
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): machacekondra mwperina
shipit_actors_other: []
automerge: automerge tests passed

click here for bot help

machacekondra

shipit

mwperina · 2018-09-03T09:07:32Z

bot_status

ansibot · 2018-09-03T09:14:53Z

Components

lib/ansible/modules/cloud/ovirt/ovirt_cluster.py
support: community
maintainers: machacekondra mwperina

lib/ansible/modules/cloud/ovirt/ovirt_datacenter.py
support: community
maintainers: machacekondra mwperina

lib/ansible/modules/cloud/ovirt/ovirt_disk.py
support: community
maintainers: machacekondra mwperina

lib/ansible/modules/cloud/ovirt/ovirt_host.py
support: community
maintainers: machacekondra mwperina

lib/ansible/modules/cloud/ovirt/ovirt_mac_pool.py
support: community
maintainers: machacekondra mwperina

lib/ansible/modules/cloud/ovirt/ovirt_network.py
support: community
maintainers: machacekondra mwperina

lib/ansible/modules/cloud/ovirt/ovirt_nic.py
support: community
maintainers: machacekondra mwperina

lib/ansible/modules/cloud/ovirt/ovirt_quota.py
support: community
maintainers: machacekondra mwperina

lib/ansible/modules/cloud/ovirt/ovirt_tag.py
support: community
maintainers: machacekondra mwperina

lib/ansible/modules/cloud/ovirt/ovirt_template.py
support: community
maintainers: machacekondra mwperina

lib/ansible/modules/cloud/ovirt/ovirt_vm.py
support: community
maintainers: machacekondra mwperina

lib/ansible/modules/cloud/ovirt/ovirt_vmpool.py
support: community
maintainers: machacekondra mwperina

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 2
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): machacekondra mwperina
shipit_actors_other: []
automerge: automerge tests passed

click here for bot help

machacekondra · 2018-09-03T10:54:45Z

shipit

mwperina · 2018-09-03T12:22:03Z

We have found out on Thursday that there was some misinformation about Community Freeze dates (already discussed that with Dylan). Ryan, is it possible to get this to 2.7? It's partial bug and partial RFE (only becuase of the need to add ID parameter) and it's quite critical for RHV.

@ryansb

mwperina · 2018-09-03T12:22:25Z

+label bug

mwperina · 2018-09-03T16:11:22Z

+label bug

sandrobonazzola · 2018-09-06T09:06:57Z

@ryansb any update?

abadger · 2018-09-06T18:48:45Z

I'm sorry, this feature wasn't even submitted until Friday, the day after final feature freeze. for 2.7. We can look at getting this into the 2.8 release but it is too late to make 2.7.

abadger · 2018-09-06T18:51:07Z

Other than version_added being updated to say "2.8" instead of 2.7, I think this is okay. Once version_added has been updated, this can be merged into devel.

mwperina

shipit

abadger · 2018-09-12T21:36:16Z

merged to devel for the 2.8 release.

jinh-dk · 2018-09-20T07:37:10Z

Can I rename oVirt template with this PR?

machacekondra · 2018-09-20T11:22:30Z

Can I rename oVirt template with this PR?

Yes, if you pass id of the old template in id, and new name in name parameter, the template will be renamed.

mnecas and others added 2 commits August 28, 2018 16:47

add renaming of ovirt

c31895f

add renaming func to ovirt cluster

be532dc

ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 31, 2018

update pep8 syntax

91cfd5c

ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 31, 2018

mwperina approved these changes Aug 31, 2018

View reviewed changes

ansibot removed the needs_triage Needs a first human triage before being processed. label Aug 31, 2018

machacekondra reviewed Aug 31, 2018

View reviewed changes

ovirt update examples in docs

45a93d1

mwperina approved these changes Aug 31, 2018

View reviewed changes

ansibot removed the community_review In order to be merged, this PR must follow the community review workflow. label Sep 3, 2018

ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core labels Sep 3, 2018

machacekondra approved these changes Sep 3, 2018

View reviewed changes

ovirt update dosc - verison_added to 2.8

3c7b587

ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core labels Sep 12, 2018

mwperina approved these changes Sep 12, 2018

View reviewed changes

abadger merged commit 2a3f338 into ansible:devel Sep 12, 2018

dagwieers added ovirt oVirt and RHV community and removed virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) labels Feb 21, 2019

ansible locked and limited conversation to collaborators Jul 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ovirt add rename functionality #44951

Ovirt add rename functionality #44951

mnecas commented Aug 31, 2018

ansibot commented Aug 31, 2018

ansibot commented Aug 31, 2018

mwperina left a comment

machacekondra Aug 31, 2018

machacekondra Aug 31, 2018

machacekondra Aug 31, 2018

machacekondra Aug 31, 2018

machacekondra Aug 31, 2018

machacekondra Aug 31, 2018

machacekondra Aug 31, 2018

machacekondra Aug 31, 2018

machacekondra Aug 31, 2018

machacekondra Aug 31, 2018

machacekondra Aug 31, 2018

machacekondra commented Aug 31, 2018

mwperina left a comment

mwperina commented Aug 31, 2018

mwperina commented Aug 31, 2018

ansibot commented Sep 3, 2018

machacekondra left a comment

mwperina commented Sep 3, 2018

ansibot commented Sep 3, 2018

machacekondra commented Sep 3, 2018

mwperina commented Sep 3, 2018

mwperina commented Sep 3, 2018

mwperina commented Sep 3, 2018

sandrobonazzola commented Sep 6, 2018

abadger commented Sep 6, 2018

abadger commented Sep 6, 2018

mwperina left a comment

abadger commented Sep 12, 2018

jinh-dk commented Sep 20, 2018

machacekondra commented Sep 20, 2018

Ovirt add rename functionality #44951

Ovirt add rename functionality #44951

Conversation

mnecas commented Aug 31, 2018

SUMMARY

ISSUE TYPE

COMPONENT NAME

ANSIBLE VERSION

ADDITIONAL INFORMATION

ansibot commented Aug 31, 2018

ansibot commented Aug 31, 2018

mwperina left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

machacekondra commented Aug 31, 2018

mwperina left a comment

Choose a reason for hiding this comment

mwperina commented Aug 31, 2018

mwperina commented Aug 31, 2018

ansibot commented Sep 3, 2018

Components

Metadata

machacekondra left a comment

Choose a reason for hiding this comment

mwperina commented Sep 3, 2018

ansibot commented Sep 3, 2018

Components

Metadata

machacekondra commented Sep 3, 2018

mwperina commented Sep 3, 2018

mwperina commented Sep 3, 2018

mwperina commented Sep 3, 2018

sandrobonazzola commented Sep 6, 2018

abadger commented Sep 6, 2018

abadger commented Sep 6, 2018

mwperina left a comment

Choose a reason for hiding this comment

abadger commented Sep 12, 2018

jinh-dk commented Sep 20, 2018

machacekondra commented Sep 20, 2018