Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding postgresql firewall rule #45077

Merged
merged 5 commits into from Oct 15, 2018
Merged

adding postgresql firewall rule #45077

merged 5 commits into from Oct 15, 2018

Conversation

zikalino
Copy link
Contributor

@zikalino zikalino commented Sep 2, 2018

SUMMARY

Adding PostgreSQL firewall rule module.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

azure_rm_postgresqlfirewallrule

ANSIBLE VERSION

2.7

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Sep 2, 2018

cc @haroldwongms @nitzmahone @trstringer @xscript @yuwzho
click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.7 This issue/PR affects Ansible v2.7 azure cloud module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Sep 2, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 2, 2018

The test ansible-test sanity --test integration-aliases [explain] failed with 1 error:

test/integration/targets/azure_rm_postgresqlfirewallrule/aliases:0:0: missing alias `shippable/azure/group[1-8]` or `unsupported`

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_postgresqlfirewallrule.py:275:1: E305 expected 2 blank lines after class or function definition, found 1

The test ansible-test sanity --test validate-modules [explain] failed with 4 errors:

lib/ansible/modules/cloud/azure/azure_rm_postgresqlfirewallrule.py:0:0: E307 version_added should be 2.8. Currently 2.5
lib/ansible/modules/cloud/azure/azure_rm_postgresqlfirewallrule.py:0:0: E322 "state" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/azure/azure_rm_postgresqlfirewallrule.py:0:0: E324 Value for "default" from the argument_spec ('present') for "state" does not match the documentation (None)
lib/ansible/modules/cloud/azure/azure_rm_postgresqlfirewallrule.py:0:0: E326 Value for "choices" from the argument_spec (['present', 'absent']) for "state" does not match the documentation ([])

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Sep 2, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 3, 2018

The test ansible-test sanity --test integration-aliases [explain] failed with 1 error:

test/integration/targets/azure_rm_postgresqlfirewallrule/aliases:0:0: missing alias `shippable/azure/group[1-8]` or `unsupported`

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_postgresqlfirewallrule.py:275:1: E305 expected 2 blank lines after class or function definition, found 1

The test ansible-test sanity --test validate-modules [explain] failed with 4 errors:

lib/ansible/modules/cloud/azure/azure_rm_postgresqlfirewallrule.py:0:0: E307 version_added should be 2.8. Currently 2.5
lib/ansible/modules/cloud/azure/azure_rm_postgresqlfirewallrule.py:0:0: E322 "state" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/azure/azure_rm_postgresqlfirewallrule.py:0:0: E324 Value for "default" from the argument_spec ('present') for "state" does not match the documentation (None)
lib/ansible/modules/cloud/azure/azure_rm_postgresqlfirewallrule.py:0:0: E326 Value for "choices" from the argument_spec (['present', 'absent']) for "state" does not match the documentation ([])

click here for bot help

@ansibleazurebot ansibleazurebot mentioned this pull request Sep 3, 2018
Closed
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Sep 5, 2018
@zikalino zikalino changed the title [WIP] adding postgresql firewall rule adding postgresql firewall rule Sep 5, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. community_review In order to be merged, this PR must follow the community review workflow. labels Sep 5, 2018
@zikalino zikalino closed this Sep 5, 2018
@zikalino zikalino reopened this Sep 5, 2018
@zikalino zikalino closed this Sep 5, 2018
@zikalino zikalino reopened this Sep 5, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 5, 2018

@Madhura-CSI @brusMX @devigned @gustavomcarmo @haroldwongms @julienstroheker @lmazuel @obsoleted @sozercan @tripdubroot @trstringer @tstringer @xscript @yaweiw @yuwzho

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 5, 2018
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Sep 5, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Sep 20, 2018
@Fred-sun
Copy link
Contributor

@zikalino I have tested PostgreSQL firewall rule function. get success full result. Could you help confirm it ready for review or not? Thanks!

@Fred-sun
Copy link
Contributor

@yuwzho @yungezz

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 6, 2018
@Fred-sun
Copy link
Contributor

Fred-sun commented Oct 9, 2018

@yuwzho @yungezz Please help review this PR and push to merged。 Thanks!

@nitzmahone nitzmahone merged commit 1c520ff into ansible:devel Oct 15, 2018
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@Tomorrow9
adding postgresql firewall rule (ansible#45077)
f102cee 
* adding postgresql firewall rule

* fixed test problems

* add state into the doc

* use lropoller

* updated samples and some naming
@dagwieers dagwieers added the postgresql PostgreSQL community label Feb 1, 2019
@dagwieers dagwieers added the database Database category label Feb 13, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitzmahone nitzmahone nitzmahone approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 azure cloud community_review In order to be merged, this PR must follow the community review workflow. database Database category module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. postgresql PostgreSQL community stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zikalino @ansibot @Fred-sun @nitzmahone @dagwieers @bcoca