Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws] ecs_taskdefinition - check for change of role arn (#44942) #45317

Merged
merged 1 commit into from
Sep 6, 2018

Conversation

s-hertel
Copy link
Contributor

@s-hertel s-hertel commented Sep 6, 2018

  • check role arn for ecs task definition

If the task role in a ECS task definition changes ansible should create a new revsion of the task definition.

(cherry picked from commit 71c4355)

SUMMARY

Backport #44942

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ecs_taskdefinition

ANSIBLE VERSION
ansible 2.7.0b1.post0

* check role arn for ecs task definition

If the task role in a ECS task definition changes ansible should create a new revsion of the task definition.

(cherry picked from commit 71c4355)
@s-hertel
Copy link
Contributor Author

s-hertel commented Sep 6, 2018

The integration tests ecs_cluster pass locally with Python 2 and 3.

@ansibot
Copy link
Contributor

ansibot commented Sep 6, 2018

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 aws backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. labels Sep 6, 2018
@abadger abadger merged commit d8c687f into ansible:stable-2.7 Sep 6, 2018
@abadger
Copy link
Contributor

abadger commented Sep 6, 2018

Merged for the 2.7.0rc1 release.

@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.7 This issue/PR affects Ansible v2.7 aws backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants