Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set defaults from params after loading files, allowing params to override #45442

Merged
merged 4 commits into from Sep 11, 2018

Conversation

fabianvf
Copy link
Contributor

Cherry-pick of #44142

  • Set defaults from params after loading files, allowing params to override

  • cleanup, add some comments

(cherry picked from commit aa01d9d)

SUMMARY

Fixes auth loading error, allowing users to provide auth settings through environment variables or module arguments.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

k8s

ANSIBLE VERSION

ADDITIONAL INFORMATION

…ride (ansible#44142)

* Set defaults from params after loading files, allowing params to override

* cleanup, add some comments

(cherry picked from commit aa01d9d)
@ansibot
Copy link
Contributor

ansibot commented Sep 10, 2018

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 10, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 10, 2018

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/module_utils/k8s/common.py:186:52: undefined-variable Undefined variable 'configuration'
lib/ansible/module_utils/k8s/common.py:187:57: undefined-variable Undefined variable 'configuration'

click here for bot help

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Sep 10, 2018
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Sep 10, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 10, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/module_utils/k8s/common.py:189:5: E303 too many blank lines (3)

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 10, 2018
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 10, 2018
@abadger abadger merged commit e354047 into ansible:stable-2.7 Sep 11, 2018
@abadger
Copy link
Contributor

abadger commented Sep 11, 2018

Merged to stable-2.7 for the 2.7.0rc2 release.

@webknjaz webknjaz removed needs_triage Needs a first human triage before being processed. labels Sep 11, 2018
ndswartz pushed a commit to ndswartz/ansible that referenced this pull request Nov 28, 2018
…ride (ansible#45442)

* Set defaults from params after loading files, allowing params to override (ansible#44142)

* Set defaults from params after loading files, allowing params to override

* cleanup, add some comments

(cherry picked from commit aa01d9d)

* Add client_from_kubeconfig function back for 2.7.0 since it's late in the 2.7 cycle to remove module_util code.
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.7 This issue/PR affects Ansible v2.7 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants