Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BusyBox support to user module #45507

Merged
merged 1 commit into from Mar 21, 2019
Merged

Add BusyBox support to user module #45507

merged 1 commit into from Mar 21, 2019

Conversation

samdoran
Copy link
Contributor

@samdoran samdoran commented Sep 11, 2018 •
edited

SUMMARY

Add class to user module to support BusyBox commands.

Fixes #23944
Fixes #30445

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

user.py

ANSIBLE VERSION
2.8

@ansibot
Copy link
Contributor

ansibot commented Sep 11, 2018

cc @sfromm
click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.8 This issue/PR affects Ansible v2.8 feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 11, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 11, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/system/user.py:2467:36: undefined-variable Undefined variable 'cmd'

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/system/user.py:354:0: ImportError: No module named q

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/system/user.py:354:0: ImportError: No module named q

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/system/user.py:354:0: ImportError: No module named 'q'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/system/user.py:354:0: ModuleNotFoundError: No module named 'q'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/system/user.py:354:0: ModuleNotFoundError: No module named 'q'

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/system/user.py:2483:1: E303 too many blank lines (4)

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/system/user.py:0:0: E321 Exception attempting to import module for argument_spec introspection, 'No module named 'q''
test/sanity/validate-modules/ignore.txt:1143:1: A102 Remove since "lib/ansible/modules/system/user.py" passes "E324" test
test/sanity/validate-modules/ignore.txt:1144:1: A102 Remove since "lib/ansible/modules/system/user.py" passes "E327" test

click here for bot help

@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Sep 13, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 21, 2018
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Oct 25, 2018
@ansibot ansibot added the system System category label Feb 17, 2019
@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Mar 20, 2019
@samdoran samdoran changed the title [WIP] Add BusyBox support to user module Add BusyBox support to user module Mar 20, 2019
@samdoran samdoran requested a review from bcoca March 20, 2019 21:45
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. labels Mar 20, 2019
@bcoca bcoca merged commit bf3e397 into ansible:devel Mar 21, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
@samdoran samdoran deleted the issue/23944-user-busybox branch July 27, 2020 20:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bcoca bcoca Awaiting requested review from bcoca

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category
Projects
None yet
Milestone
No milestone
4 participants
@samdoran @ansibot @bcoca @jborean93