Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect use of subprocess.CalledProcessError #45890

Merged
merged 2 commits into from
Sep 20, 2018
Merged

Fix incorrect use of subprocess.CalledProcessError #45890

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e656958
Fix incorrect use of subprocess.CalledProcessError
dagwieers Sep 20, 2018
8d21a10
Implement suggested/preferred improvement
dagwieers Sep 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion test/sanity/code-smell/docs-build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@ def main():
stdout, stderr = sphinx.communicate()

if sphinx.returncode != 0:
raise subprocess.CalledProcessError(sphinx.returncode, cmd, output=stdout, stderr=stderr)
print("Command '%s' failed with status code: %d" % (' '.join(cmd), sphinx.returncode))
print(stdout)
print(stderr)
return

with open('docs/docsite/rst_warnings', 'r') as warnings_fd:
output = warnings_fd.read().strip()
Expand Down